Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: don't early exit with error if root is not a git dir #224

Merged
merged 3 commits into from
Aug 28, 2023
Merged

hotfix: don't early exit with error if root is not a git dir #224

merged 3 commits into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. hotfix: don't early exit with error if root is not a git dir 

    This broke reporting workflow in a case where artifact was being reported from a docker container.
Previously, Fetching head manually was done in the end, after checking all env variables. In the last change, we were still doing an early exit
when the git rev parse command threw an error, not allowing the flow to reach till extracting git commit from env variable set in docker container.

This change restores the previous workflow.
    @srijan-deepsource
    srijan-deepsource committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    068e81d View commit details
    Browse the repository at this point in the history

  2. move GIT_COMMIT_SHA env lookup to the top

    @srijan-deepsource
    srijan-deepsource committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b62d6fa View commit details
    Browse the repository at this point in the history

  3. don't make another env lookup call

    @srijan-deepsource
    srijan-deepsource committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    21fe79e View commit details
    Browse the repository at this point in the history