feat: add cfn-lint #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijan-deepsource
requested changes
Oct 27, 2023
There was a problem hiding this comment.
I see that a good number of titles are in title-case. We use sentence-case for titles. Can you please take care of them?
Also, add a test for cfn lint's sarif file to make sure our sarif-parser works properly with this.
Ref: https://github.com/DeepSourceCorp/community-analyzers/tree/master/tests
analyzers/cfn-lint/.deepsource/analyzer/issues/CFLIN-E0002.toml
Outdated
Show resolved
Hide resolved
analyzers/cfn-lint/.deepsource/analyzer/issues/CFLIN-W8001.toml
Outdated
Show resolved
Hide resolved
analyzers/cfn-lint/.deepsource/analyzer/issues/CFLIN-W8003.toml
Outdated
Show resolved
Hide resolved
Co-authored-by: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> Signed-off-by: Vishnu Jayadevan <68588475+vishnu-deepsource@users.noreply.github.com>
Changes: - Add end to end parsing test - Fix assets being copied in the Dockerfile - Explicitly log the info passed to sentry.raise_info - Add instruction about adding fixture for parsing test in readme - Change workdir - fix dependencies installation in the image
Changes: - Check the artifact result's hash before parsing. Ignore the artifact if the hash is same. - Raise sentry info alerts for unsanitised issues - fix type hints - add missing tests
Armory is an in-house github action to validate the Analyzer directories and issues. It highlights the issues in the PRs that can lead to unexpected behaviours during analyzer syncs. --------- Signed-off-by: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com>
Slither: https://github.com/crytic/slither --------- Co-authored-by: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com>
Co-authored-by: Eshaan Bansal <eshaan@deepsource.io> Signed-off-by: Vishnu Jayadevan <68588475+vishnu-deepsource@users.noreply.github.com>
|
Can you add an entry for cfn-lint in the README.md as well? |
eshaan-deepsource
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.