Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Relay Bridge #318

Merged
merged 8 commits into from
Jan 5, 2025
Merged

Add Relay Bridge #318

merged 8 commits into from
Jan 5, 2025

Conversation

pedromcunha
Copy link
Contributor

Added Relay bridge and ran the tests on base. I have a few questions:

  • Should we specify RPC urls for specific chains which may not be configured in viem?
  • I saw some logic here relating to solana and excluding some chains. Should I add relay to this list? What is it doing exactly? Seems like it's skipping RPC checks because presumably these bridges have offchain events?
  • Can you explain how TVL is calculated? We want to make sure the calculations add up there.

Thank you!

@vrtnd
Copy link
Member

vrtnd commented Dec 17, 2024

Hello, @pedromcunha.

Should we specify RPC urls for specific chains which may not be configured in viem?

U need to add them here https://github.com/DefiLlama/defillama-sdk

I saw some logic here relating to solana and excluding some chains. Should I add relay to this list? What is it doing exactly?
Seems like it's skipping RPC checks because presumably these bridges have offchain events?

Yes, we dont support solana onchain events

Can you explain how TVL is calculated? We want to make sure the calculations add up there.

It isnt tvl, we calculate volume
Query: https://github.com/DefiLlama/bridges-server/blob/master/src/utils/wrappa/postgres/query.ts#L115

@pedromcunha
Copy link
Contributor Author

Ok, I've added the configurations to the SDK here:
DefiLlama/defillama-sdk#158

Regarding bitcoin and solana, should the chain ids be left blank when mapping our data to events?

@pedromcunha
Copy link
Contributor Author

Hello @vrtnd, any update here? Happy to fix anything so we can get this merged.

@vrtnd vrtnd merged commit 85ab5ab into DefiLlama:master Jan 5, 2025
vrtnd added a commit that referenced this pull request Jan 8, 2025
This reverts commit 85ab5ab, reversing
changes made to 7347cd2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants