Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Springboard fees #2182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Springboard fees #2182

wants to merge 3 commits into from

Conversation

dtmkeng
Copy link
Contributor

@dtmkeng dtmkeng commented Dec 5, 2024

No description provided.

@llamatester
Copy link

The springboard.ts adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees springboard.ts

🦙 Running SPRINGBOARD.TS adapter 🦙
---------------------------------------------------
Start Date:	Wed, 04 Dec 2024 03:31:37 GMT
End Date:	Thu, 05 Dec 2024 03:31:37 GMT
---------------------------------------------------

BSC 👇
Backfill start time: 5/11/2024
NO METHODOLOGY SPECIFIED
Daily fees: 43.62 k
Daily revenue: 43.62 k
End timestamp: 1733369496 (2024-12-05T03:31:36.000Z)

@dtmkeng dtmkeng marked this pull request as ready for review December 5, 2024 06:02
@llamatester
Copy link

The springboard.ts adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees springboard.ts

🦙 Running SPRINGBOARD.TS adapter 🦙
---------------------------------------------------
Start Date:	Wed, 04 Dec 2024 06:37:47 GMT
End Date:	Thu, 05 Dec 2024 06:37:47 GMT
---------------------------------------------------

BSC 👇
Backfill start time: 5/11/2024
NO METHODOLOGY SPECIFIED
Daily fees: 53.92 k
Daily revenue: 53.92 k
End timestamp: 1733380666 (2024-12-05T06:37:46.000Z)

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue with this approach is, when project removes tokens from the address, it will incorrectly show up as negative fees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants