-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverts Nitrogen Tank Removal #1007
Reverts Nitrogen Tank Removal #1007
Conversation
I really, really need to reclean my fork to fix the merge history :O |
i actually think this was a good change by WD and makes slimes more meaningfully different. if slimes can find nitrogen just as easily as every other species can find O2, why make them breathe nitrogen at all? |
|
(salv takes a n2 can rather, breathing air mix from a tank is bad for every species) |
All the lines touching upstream files need DV notes. |
Besides adding comments, this looks good other than I'd argue we don't need to add them to Engie/CE lockers as long as we have tank dispensers mapped in the dept. Same could probably go for Salv. |
@@ -6,6 +6,8 @@ | |||
- type: StorageFill | |||
contents: | |||
- id: ClothingOuterHardsuitSpatio | |||
- id: OxygenTankFilled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these. They can use tank dispensers. If dispensers aren't mapped, we will fix that.
@@ -82,6 +82,8 @@ | |||
contents: | |||
- id: ClothingOuterHardsuitAtmos | |||
- id: ClothingMaskGasAtmos | |||
- id: OxygenTankFilled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these. They can use tank dispensers. If dispensers aren't mapped, we will fix that.
So, upstream just merged this 26752. I'm inclined to go with it. Seems reasonable. We could maybe still add a chance for them to spawn in emergency toolboxes though. |
that pr.... feels like such a bloat on mapping tbh. |
I think the idea is that you replace some of the emergency lockers with these, not add more |
About the PR
Reverts Wizden commit that removes Nitrogen Tanks from lockers
Why / Balance
Slimes deserve to breathe too. Loadouts should be made rather than removing tanks. Why does a human get a tank in his locker, but someone has to go dive maints or beg Atmos/Engineering because they picked a Slime?
Changelog
🆑 DangerRevolution