Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts Nitrogen Tank Removal #1007

Closed

Conversation

DangerRevolution
Copy link
Contributor

About the PR

Reverts Wizden commit that removes Nitrogen Tanks from lockers

Why / Balance

Slimes deserve to breathe too. Loadouts should be made rather than removing tanks. Why does a human get a tank in his locker, but someone has to go dive maints or beg Atmos/Engineering because they picked a Slime?

Changelog

🆑 DangerRevolution

  • add: After a campaign from Slime Rights Activists, Nitrogen tanks have been readded to standard lockers.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Mar 25, 2024
@DangerRevolution
Copy link
Contributor Author

I really, really need to reclean my fork to fix the merge history :O

@rosieposieeee
Copy link
Contributor

i actually think this was a good change by WD and makes slimes more meaningfully different. if slimes can find nitrogen just as easily as every other species can find O2, why make them breathe nitrogen at all?

@DangerRevolution
Copy link
Contributor Author

DangerRevolution commented Mar 25, 2024

good change by WD [...] makes slimes more meaningfully different [...] why make them breathe nitrogen at all?

  1. Slimes breathe nitrogen because they couldn't port Ethereals; as there's no systems to support them so they ported something simpler for racial variety that they could do a minor tweak to change.
  2. Slimes are on their way out from Wizden, have no content, are the worst Wizden race and with this change; if you haven't gone to beg Atmos/Engi for a Nitrogen Tank or gone to dive through maints then they die when spaced or gassed, they already take extra damage from the Barotrauma.
  3. this still impacts Salvage, who need to take an air canister rather than just O2 + Slimes don't get any relevant tank in their survival kits.

@deltanedas
Copy link
Member

(salv takes a n2 can rather, breathing air mix from a tank is bad for every species)

@IamVelcroboy
Copy link
Member

All the lines touching upstream files need DV notes.

@IamVelcroboy
Copy link
Member

Besides adding comments, this looks good other than I'd argue we don't need to add them to Engie/CE lockers as long as we have tank dispensers mapped in the dept. Same could probably go for Salv.

@DangerRevolution DangerRevolution deleted the i-hate-specism branch March 31, 2024 08:36
@DangerRevolution DangerRevolution restored the i-hate-specism branch March 31, 2024 08:37
@@ -6,6 +6,8 @@
- type: StorageFill
contents:
- id: ClothingOuterHardsuitSpatio
- id: OxygenTankFilled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these. They can use tank dispensers. If dispensers aren't mapped, we will fix that.

@@ -82,6 +82,8 @@
contents:
- id: ClothingOuterHardsuitAtmos
- id: ClothingMaskGasAtmos
- id: OxygenTankFilled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these. They can use tank dispensers. If dispensers aren't mapped, we will fix that.

@IamVelcroboy
Copy link
Member

So, upstream just merged this 26752. I'm inclined to go with it. Seems reasonable. We could maybe still add a chance for them to spawn in emergency toolboxes though.

@Adrian16199
Copy link
Contributor

So, upstream just merged this 26752. I'm inclined to go with it. Seems reasonable. We could maybe still add a chance for them to spawn in emergency toolboxes though.

that pr.... feels like such a bloat on mapping tbh.
also I do like the idea on the chance spawnin in emergency toolboxes.

@IamVelcroboy
Copy link
Member

that pr.... feels like such a bloat on mapping tbh.

I think the idea is that you replace some of the emergency lockers with these, not add more

@DangerRevolution DangerRevolution deleted the i-hate-specism branch April 20, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants