Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craftable muskets + Flintlocks #1008

Merged
merged 35 commits into from
May 26, 2024

Conversation

Tryded
Copy link
Contributor

@Tryded Tryded commented Mar 25, 2024

About the PR

Makes a Musket meant for DeltaV with its own ammo and crafting recipe.

The Musket has multiple parts that all have to be individually crafted to make the musket.

Why / Balance

Line Infantry will be funny and using the weapon by yourself is kind of bad as it takes 8 seconds to fire again. You can dual wield with the flint locks.

Each Cartridge deals 30 piercing damage.

Technical details

YAML Only

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Tryded

  • add: Added a way for muskets and musket cartridges (NOT .60) to be crafted.

@github-actions github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

RSI Diff Bot; head commit a49faac merging into fb62f23
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/bayonet.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Misc/modular_breech.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Misc/modular_trigger.rsi

State Old New Status
base Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Casings/musket_casing.rsi

State Old New Status
base Added

Edit: diff updated after a49faac

@Tryded
Copy link
Contributor Author

Tryded commented Mar 25, 2024

Still trying to figure out how to make it reload slower without changing the firerate as the firerate makes it so that it is basically impossible to quickdraw it even when it is already reloaded.

@Tryded
Copy link
Contributor Author

Tryded commented Mar 25, 2024

Ready for review

@Bonktrauma
Copy link
Contributor

Ready for review

Will it still allow .60?

@Tryded
Copy link
Contributor Author

Tryded commented Mar 26, 2024

Will it still allow .60?

It uses it's own musket cartridge which deals 30 pierce and is craftable

@Tryded
Copy link
Contributor Author

Tryded commented Apr 6, 2024

hmm

@Tryded
Copy link
Contributor Author

Tryded commented Apr 19, 2024

Hm.. It's been an while

@Tryded
Copy link
Contributor Author

Tryded commented May 2, 2024

Does anyone have concerns?

Tryded and others added 2 commits May 26, 2024 10:00
Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Signed-off-by: Tryded <139474617+Tryded@users.noreply.github.com>
@Colin-Tel Colin-Tel enabled auto-merge (squash) May 26, 2024 15:01
@Colin-Tel Colin-Tel merged commit 9618366 into DeltaV-Station:master May 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants