-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty Disposals #1009
Pretty Disposals #1009
Conversation
RSI Diff Bot; head commit 6694273 merging into 9b6fbd2 Resources/Textures/DeltaV/Structures/Piping/disposal.rsi
|
bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line |
are all the pipes & unused intake sprites necessary in the new folder? |
space disposals relies on it, otherwise i would have to touch upstream files
probably not, ill cut them out |
you can PR the old sprites & PR the space sprites; and ask for the old sprites to be merged first so it works |
yeah but if it was undone, you'd have to undo both anyway |
The question is, should I warn the prisoners in Hive.... After all, there is an observation window set up so other prisoners can point and laugh 😄 |
amazing, god bless my beloved old chutes |
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should fix the tests
thanks death
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
lol |
Co-authored-by: Fluffiest Floofers <thebluewulf@gmail.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
Looks fine to me. Just waiting to see if any other maintainers have thoughts...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long live the king
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
…json Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Fix tests then this looks good. |
Any update? Tests are still failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should fix le PR
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi/meta.json
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
…json Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
laziness ops wins again |
👻 |
Should revive this |
Resources/Prototypes/DeltaV/Entities/Structures/Piping/Disposal/space_disposal.yml
Outdated
Show resolved
Hide resolved
As the oldest open PR in the repo currently (the actual oldest one is Danger's Angle draft PR,) what's the consensus on if we want old disposals? I'm so used to the new sprite that I kinda forgot how nice this one looked. |
Co-authored-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com> Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
I would like old disposals back, I think this is neat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this looks fine. Let's try it.
About the PR
Brings back the old disposal sprites, and adds a 'space' variant that warns you that it goes to space, for the maps that have spaced disposals (Hive's perma, Sub's everything.) (Otherwise, the space one is no different than a normal one.)
If anyone has a better idea than a generic yellow warning triangle I'll sprite it.
Why / Balance
The new sprites were ugly, and I had to make a new RSI for the space one anyway (or touch the upstream RSI, but I didn't want to.)
Media
Changelog
🆑