Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase moth color blending strength by 25% and replace color blending with the intended helper function #1015

Merged
merged 3 commits into from
May 6, 2024

Conversation

NullWanderer
Copy link
Contributor

About the PR

This would need to be properly tested to make sure it still achieves the desired effect. My hope is that by increasing the amount of color blending done, that it'd allow for greater freedom with the colors available

Why / Balance

Bright purple moff :3

Technical details

Color.InterpolateBetween is what should be used here, instead of ripping apart the color and lerping everything manually. This shouldn't really affect anything too severely except making me happy by having a shorter function

Breaking changes

It might cause players to have to reset the colors on their moth characters, but since its just a blending change it'd probably just come down to moving the sliders up slightly

Changelog
🆑

  • tweak: The color mixing applied to moths has been increased in strength by 25%.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Mar 27, 2024
Copy link
Contributor

@A-z-z-y A-z-z-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes code more readable (self-documenting functions my beloved.)

@A-z-z-y A-z-z-y marked this pull request as ready for review May 6, 2024 15:17
@A-z-z-y A-z-z-y enabled auto-merge (squash) May 6, 2024 15:18
@A-z-z-y A-z-z-y merged commit 8f9113b into DeltaV-Station:master May 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants