Uncomment metem board in RandomBoards spawner #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-novas
force-pushed
the
random-boards-tweak
branch
from
5a32a30
to
6f0f0f4
Compare
IamVelcroboy
approved these changes
Mar 28, 2024
nearlyNonexistent
referenced
this pull request
in nearlyNonexistent/Horizon-Station
Apr 14, 2024
VMSolidus
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
May 4, 2024
## Mirror of PR #1024: [Uncomment metem board in RandomBoards spawner](DeltaV-Station/Delta-v#1024) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/158120145?v=4" width="16"/><a href="https://github.com/stellar-novas"> stellar-novas</a> at 2024-03-28 15:44:05 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/158120145?v=4" width="16"/><a href="https://github.com/stellar-novas"> stellar-novas</a> at 2024-03-28 15:56:19 UTC</aside> <sup> `bb34cdacf7ddaf6b88da5244bbb9a64072b28415` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > <!-- What did you change in this PR? --> > Title > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > It was only commented out because metem wasn't in the rebase initially. It now is, so it should be back. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > N/A > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > > I don't think minor loot pool changes are worthy of a CL? I can add one if it is. </details> Co-authored-by: stellar-novas <stellar_novas@riseup.net> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Title
Why / Balance
It was only commented out because metem wasn't in the rebase initially. It now is, so it should be back.
Technical details
N/A
Media
Breaking changes
Changelog
I don't think minor loot pool changes are worthy of a CL? I can add one if it is.