-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New horns for oni. #1030
Merged
Merged
New horns for oni. #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Localization
Changes any ftl files
Changes: Sprite
Changes any png or json in an rsi
Changes: YML
Changes any yml files
labels
Mar 28, 2024
DEATHB4DEFEAT
suggested changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to the DeltaV namespace
Done |
NullWanderer
approved these changes
Mar 28, 2024
This review is blocking merge and I can't find a way to dismiss it. Looks like it was addressed. |
DEATHB4DEFEAT
approved these changes
Apr 4, 2024
nearlyNonexistent
referenced
this pull request
in nearlyNonexistent/Horizon-Station
Apr 14, 2024
* New horns for oni. * Update meta.json * That one cursed lack of space * Do what was requested * Update meta.json --------- Co-authored-by: Velcroboy <107660393+IamVelcroboy@users.noreply.github.com>
VMSolidus
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
May 4, 2024
## Mirror of PR #1030: [New horns for oni.](DeltaV-Station/Delta-v#1030) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/144424013?v=4" width="16"/><a href="https://github.com/Adrian16199"> Adrian16199</a> at 2024-03-28 18:32:23 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/144424013?v=4" width="16"/><a href="https://github.com/Adrian16199"> Adrian16199</a> at 2024-04-04 21:43:48 UTC</aside> <sup> `d87b4b048a434e4d2c9ac23d4da4a46fae0d5c30` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review - Changes: Localization - Changes: Sprite --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > I added new horns and fixed marking ftl > Sprites were made by PS3MOIRA > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > These sprites were made and simply it took a moment from various of reasons for them to be pull resquested here. > So I have simply ported them here myself. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > ![image](https://github.com/DeltaV-Station/Delta-v/assets/144424013/ac93e16c-e834-432e-af82-1da29ab4aece) > ![image](https://github.com/DeltaV-Station/Delta-v/assets/144424013/8527f0fc-67a6-441d-b6c0-eb42daa76a9e) > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > > 🆑 > - add: Added new horn designs for onis. > </details> Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Sep 6, 2024
oni.](DeltaV-Station/Delta-v#1030) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/144424013?v=4" width="16"/><a href="https://github.com/Adrian16199"> Adrian16199</a> at 2024-03-28 18:32:23 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/144424013?v=4" width="16"/><a href="https://github.com/Adrian16199"> Adrian16199</a> at 2024-04-04 21:43:48 UTC</aside> <sup> `d87b4b048a434e4d2c9ac23d4da4a46fae0d5c30` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review - Changes: Localization - Changes: Sprite --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > I added new horns and fixed marking ftl > Sprites were made by PS3MOIRA > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > These sprites were made and simply it took a moment from various of reasons for them to be pull resquested here. > So I have simply ported them here myself. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > ![image](https://github.com/DeltaV-Station/Delta-v/assets/144424013/ac93e16c-e834-432e-af82-1da29ab4aece) > ![image](https://github.com/DeltaV-Station/Delta-v/assets/144424013/8527f0fc-67a6-441d-b6c0-eb42daa76a9e) > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > > 🆑 > - add: Added new horn designs for onis. > </details> Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: Localization
Changes any ftl files
Changes: Sprite
Changes any png or json in an rsi
Changes: YML
Changes any yml files
Status: Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
I added new horns and fixed marking ftl
Sprites were made by PS3MOIRA
Why / Balance
These sprites were made and simply it took a moment from various of reasons for them to be pull resquested here.
So I have simply ported them here myself.
Technical details
Media
Breaking changes
Changelog
🆑