Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tourist #1037

Closed
Closed

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Mar 30, 2024

About the PR

Title.

Why / Balance

A) I want this for a map in the works.
B) Useful for other maps
C) Again, provides a reason for someone to be on station more so than a miscellaneous "make your own, you're just someone on here" and Tourist is more of an external role; allowing for concepts such as "I don't know every single job on this station, what do you do here man dressed in yellows" which we normally can't RP. + can be given tours, the potential is higher and the requirement for someone to RP this; and for someone to understand IC that "hey, this person doesn't know the station inside and out" is more interesting.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
no changelog

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Mar 30, 2024
@DangerRevolution
Copy link
Contributor Author

also ready once i make something interesting for their job & PDA locale

@FluffiestFloof
Copy link
Contributor

Mark it as draft if it isn't ready. Also this is literally Passenger but with a different name?

@DangerRevolution
Copy link
Contributor Author

this is literally Passenger but with a different name, icon (soon) and starting outfit

Yes

@rosieposieeee
Copy link
Contributor

to be honest i think this is going to be the first time i ever say bloat. all of these extra passenger roles could just be handled through the loadout system. there was talk of letting people select different job titles too alongside that, i think that would be... better than adding a bunch of roles that do practically nothing

not to mention theres a really cool upstream pr for tourist as a minor "antag" which i think would be more interesting

@DangerRevolution
Copy link
Contributor Author

all of these extra passenger roles could just be handled through the loadout system

when loadout comes I'd be happy to merge these together into a Passenger megaclass along with the rest of the role bloat

@rosieposieeee
Copy link
Contributor

all of these extra passenger roles could just be handled through the loadout system

when loadout comes I'd be happy to merge these together into a Passenger megaclass along with the rest of the role bloat

i think its a little silly to, in the meantime, add a bunch of roles that you KNOW are going to be removed, along with all the map edits itll require

@DangerRevolution
Copy link
Contributor Author

all of these extra passenger roles could just be handled through the loadout system

when loadout comes I'd be happy to merge these together into a Passenger megaclass along with the rest of the role bloat

i think its a little silly to, in the meantime, add a bunch of roles that you KNOW are going to be removed,

I don't know they're going to be removed as I have no assurances that Loadouts will support manifest edits following ID changes; I don't even know if loadouts will be merged / finished and I don't know if we'll accept the amount of edits I want for loadouts.

along with all the map edits itll require

This is optional for mappers; up to them if they want to have Tourists or not. I personally would want it for my map as a Passenger replacement, but other maps can not include them and it creates no extra burden for them.

@IamVelcroboy
Copy link
Member

If this is for a specific map, I'd say add it along with the map PR. I didn't look too close at it but the tourist midround PR from upstream seems like it would be better than this. Or, when loadouts, I guess.

@DangerRevolution DangerRevolution mentioned this pull request Apr 17, 2024
1 task
@DangerRevolution DangerRevolution deleted the Tourist branch April 20, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants