Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Engineering Update #1042

Merged
merged 51 commits into from
May 20, 2024

Conversation

Squishy77
Copy link
Contributor

About the PR

Made the re machine craft able and researchable (alternative research) Added a ton of new rebase items into the re-able list, alongside some side grades like the space heater being now craft able- if wanted.

Why / Balance

The re machine was out of date in both recipes and upgrades- this proposes a change in that, now Mutiple things can be red at once and you can logically set up a farm of low difficulty items to research for tech disks to sell to cargo - alongside the side tiers(stuff like space heaters and hand held crew monitors{want to add med-huds and binary keys in the future as a re-able only crafts}) and High tier researches(Blukies and lucky finds of high tier items from salvage or crew). My goal is to make it a reasonable alternative, that can be used to craft items not usually craft able, but not too abuseable in the future, also to give the thief antag another way to obtain tech disks other than the disk printer. Also, I commented out the handheld- teleporter re-ability due to lag it caused (in the past when it was impmented in the research tree) and it not being linked up to a lathe in the code.

Technical details

I mostly just extended the re code to the new post rebase items and made the re-machine realistically craftable by changing the diamonds it needed into plasma glass and removing borg arms and the extra glass it needed.

  • I have added screenshots/videos to this PR showcasing its changes in game.

image
image
image
image
image
image
image

Changelog

  • add: made the R.E-machine reasonably craft able, researchable and added a ton of re-able items to it

I fucked up bad now im gonna fix it

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Dear god i hope

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
adds the mass scaner to the list

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
adds boards!

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
dont really know about the deck guns and space heater ill have to test em

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
I hope this is ok

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
made the shuttle console consistent with its tier in the tech tree.

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
yay?

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
hope this works

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
adds all the holo projectors.

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
lagged the server I am told.

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
…ial one i had planed

that-

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
i forgot!

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
quadruple check of the code

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
@github-actions github-actions bot added the Changes: YML Changes any yml files label Mar 31, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly fine, i really think you should grab all the reverse-engineerable entities into a .txt file and retro-actively go through them to rebalance research difficulty.

Fixes lines

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Adds references to delta for changed recipies

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Removes the re completed to the hand held teliporter

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Fixes spacing and adds a delta reference 

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
@deltanedas
Copy link
Member

almost all re'd recipes arent available in lathes right now there should probably be a test to prevent this in the future

Fixes up listing i think

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
@Squishy77
Copy link
Contributor Author

What do you mean? I mostly added the ones I knew that had recipes. You talking about things like the hand held and bluespace parts? I could try to figure them out in the future.

Squishy77 and others added 8 commits April 3, 2024 18:26
…chine/production.yml

Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
…chine/production.yml

Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
…chine/production.yml

Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
refernaces nanyo not delta

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
fixed a tag that would prevent building.

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
FIXES THAT ONE SPACE


Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
adds the borg arms back

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
all set

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid

@github-actions github-actions bot added the Status: Merge Conflict Fix your PR! label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

fixed two ids

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
fixed a unnecessary sister string.

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
@github-actions github-actions bot removed the Status: Merge Conflict Fix your PR! label Apr 10, 2024
@github-actions github-actions bot added the Status: Merge Conflict Fix your PR! label Apr 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
@github-actions github-actions bot removed the Status: Merge Conflict Fix your PR! label Apr 30, 2024
deltanedas
deltanedas previously approved these changes Apr 30, 2024
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Squishy77 and others added 2 commits April 30, 2024 11:36
Signed-off-by: Squishy77 <165165480+Squishy77@users.noreply.github.com>
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging if doesnt break tests

@Squishy77
Copy link
Contributor Author

damnit what the heck is a saw mill

@deltanedas deltanedas merged commit ba28b83 into DeltaV-Station:master May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants