Add space ferrets as a midround event #1045

NullWanderer · 2024-04-01T19:41:33Z

About the PR

Silly brainrot creatures, now with 99%* less brainrot!

Saves the Legally Distinct Space Ferrets:tm: from the April fools update, because they're just too cute! Makes some big changes and cleanups to make sure they are actually fit for MRP

~~TODO:~~

~~Ghost role rules~~
~~Backflip sprite~~
~~Wawa!~~

Removed:

Brainrot mechanic
The ability to go under doors
ID card slot
Headset slot

Tweaked

Their speed has been nerfed to the same speed as a mouse
Their melee damage has been reduced by 10
The amount of food they need to eat to complete their objective has been reduced to 1/3rd of the original
They no longer get hungry as fast

Why / Balance

Wawa!

Changelog
🆑

add: Legally distinct space ferrets from the april fools update have been made a permanent addition! Wawa!

* wawa * Minor cleanup, change intro/outro sfx * Fix yaml * wawaskillissue * challenge * Remove unusable audio, update spriting * Kill remaining wawa sfx * Fix name prefix * these sound effects cost £460 * these attributations cost £0 * louder, mono wawa noises * Audio fixes * Tidy server system * Code tidy-up, wawa * Remove locstring hardcodes * Bug fixes, wawa * meta update, wawa * Force antagprotoid to be hardcoded because yaml validation cringe, wawa

github-actions · 2024-04-01T19:42:06Z

RSI Diff Bot; head commit 3a0722a merging into 8a15020
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Interface/Actions/backflip.rsi

State	Old	New	Status
backflip			Added

Resources/Textures/DeltaV/Mobs/Animals/spaceferret.rsi

State	Old	New	Status
spaceferret			Added
spaceferret_crit			Added
spaceferret_dead			Added
spaceferret_eepy			Added

Edit: diff updated after 3a0722a

deltanedas · 2024-04-01T19:56:16Z

unreal shitter species since you can walk under doors and have hands

NullWanderer · 2024-04-01T20:00:20Z

unreal shitter species since you can walk under doors and have hands

That'll be changed

NullWanderer · 2024-04-01T21:37:59Z

Wa? Wawa! Waa...

Resources/Prototypes/DeltaV/Entities/Mobs/NPCs/spaceferret.yml

…4/01-Slugcats

…w only the name remains

Adrian16199

Otherwise, looks fine

Content.Server/Interaction/InteractionPopupSystem.cs

Content.Shared/Nutrition/EntitySystems/HungerSystem.cs

Resources/Audio/Animals/attributions.yml

NullWanderer · 2024-04-03T22:21:35Z

The chances of them being able to just go and cause a lot of havoc is also reduced further by the fact they have the chance to just spawn in a room they wont be able to get out of on their own

deltanedas · 2024-04-03T22:05:37Z

Content.Client/DeltaV/SpaceFerret/CanHibernateSystem.cs

+            return;
+        }
+
+        comp.LayerSetState(0, args.SpriteStateId);


ideally use appearance for this otherwise remove from the event and just use the component directly along with actual validation

deltanedas · 2024-04-03T22:06:04Z

Content.Client/DeltaV/SpaceFerret/CanBackflipSystem.cs

+            return;
+        }
+
+        _animation.Play(uid.Value, new Animation


no validation of any kind here either...

Not sure what you mean here?

it used to let malf clients play any sound which is Not Good

now it cant do that, also can probably get mob from message session so player cant even spoof the entity of an actual ferret

Content.Server/DeltaV/SpaceFerret/Systems/CanBackflipSystem.cs

Content.Server/DeltaV/SpaceFerret/Systems/CanHibernateSystem.cs

Content.Shared/Content.Shared.csproj

Resources/Locale/en-US/deltav/ghost/roles/ghost-role-component.ftl

Resources/Locale/en-US/deltav/objectives/conditions/spaceferret.ftl

Resources/Locale/en-US/deltav/prototypes/roles/antags.ftl

Resources/Prototypes/DeltaV/Roles/Antags/spaceferret.yml

Content.Client/DeltaV/SpaceFerret/CanBackflipSystem.cs

NullWanderer · 2024-04-03T22:53:52Z

I pushed a ton of changes that hopefully addresses some of these

NullWanderer · 2024-04-03T22:57:52Z

I think I fucked some shit up, I need some sleep before I continue this, I have no idea what I'm doing :<

github-actions · 2024-05-07T21:22:13Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Azzy <azzydev@icloud.com>

github-actions · 2024-05-18T20:00:13Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ghost · 2024-09-02T11:57:11Z

Unfortunately, gonna close this for two reasons -

It has not been touched in four months. I do not think there is intent to work on this anymore
When I get to it, I'm going to port a non-antag version of the wawa so we can have them and it will ideally have a mix of changes from this PR and the floof version. They also won't be antags

FairlySadPanda and others added 3 commits April 1, 2024 02:26

Quick hotfix since panda is screaming at me in vc

07c6750

Skug

524b1bc

github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Apr 1, 2024

NullWanderer added 2 commits April 1, 2024 21:47

Unrot the brain

2588150

Its just spaceferret now

ddd1218

NullWanderer added 2 commits April 1, 2024 21:57

Wawa!

c039441

Wawa?

95d664d

NullWanderer added 10 commits April 1, 2024 22:03

Deshitter the species part 1

d56e2df

Separate out upstream changes

d11b4d7

Remove csproj brainrot

9b6c8c2

Finally cut everything out into separate files

4219094

Wawa...

f8779fc

Localized wawa

ab0245f

Am kinda dum

be49ffc

Event

04d6d28

Wawa

f38f97b

Hopefully the final wa

b196164

NullWanderer marked this pull request as ready for review April 1, 2024 21:35

NullWanderer added 4 commits April 1, 2024 23:47

He do flip tho

4ddea05

Brainrot

a0a494e

Fix inventory

2305f30

Objective

28025c9

Merge branch 'master' into 2024/04/01-Slugcats

56b4138

deltanedas reviewed Apr 3, 2024

View reviewed changes

Resources/Prototypes/DeltaV/Entities/Mobs/NPCs/spaceferret.yml Outdated Show resolved Hide resolved

NullWanderer added 3 commits April 4, 2024 00:03

Actually commit the hunger change

2345cd6

Merge remote-tracking branch 'origin/2024/04/01-Slugcats' into 2024/0…

c176c31

…4/01-Slugcats

Remove last LDSF mentions and replace them with just space ferret. No…

577b6cd

…w only the name remains

NullWanderer changed the title ~~Wawa brainrot creatures~~ Add space ferrets as a midround event Apr 3, 2024

Adrian16199 reviewed Apr 3, 2024

View reviewed changes

Add notes for core modifications

eda1502

deltanedas reviewed Apr 3, 2024

View reviewed changes

NullWanderer added 8 commits April 4, 2024 00:32

Backflip event cleanup

32d8f2b

Purge last LDSF mentions

18215a2

Put objective localization in the prototype

7bb068b

CanHibernate changes, may need to come back to this one...

301fca8

Wawa!

f104fef

The brainrot is getting to me

6ac2aec

Misc changes

48d02ce

Revert Content.Shared.csproj changes

7b50156

I think I need eepy irl

6a9ea44

NullWanderer marked this pull request as draft April 3, 2024 22:58

github-actions bot added the Status: Merge Conflict Fix your PR! label May 7, 2024

Merge branch 'master' into 2024/04/01-Slugcats

3a0722a

Signed-off-by: Azzy <azzydev@icloud.com>

github-actions bot removed the Status: Merge Conflict Fix your PR! label May 8, 2024

github-actions bot added the Status: Merge Conflict Fix your PR! label May 18, 2024

ghost closed this Sep 2, 2024

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add space ferrets as a midround event #1045

Add space ferrets as a midround event #1045

NullWanderer commented Apr 1, 2024 •

edited by ghost

Loading

github-actions bot commented Apr 1, 2024 •

edited

Loading

deltanedas commented Apr 1, 2024

NullWanderer commented Apr 1, 2024

NullWanderer commented Apr 1, 2024

Adrian16199 left a comment

NullWanderer commented Apr 3, 2024

deltanedas Apr 3, 2024

deltanedas Apr 3, 2024

NullWanderer Apr 3, 2024

deltanedas Apr 4, 2024

NullWanderer commented Apr 3, 2024

NullWanderer commented Apr 3, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 18, 2024

ghost commented Sep 2, 2024

Add space ferrets as a midround event #1045

Add space ferrets as a midround event #1045

Conversation

NullWanderer commented Apr 1, 2024 • edited by ghost Loading

About the PR

Why / Balance

github-actions bot commented Apr 1, 2024 • edited Loading

deltanedas commented Apr 1, 2024

NullWanderer commented Apr 1, 2024

NullWanderer commented Apr 1, 2024

Adrian16199 left a comment

Choose a reason for hiding this comment

NullWanderer commented Apr 3, 2024

deltanedas Apr 3, 2024

Choose a reason for hiding this comment

deltanedas Apr 3, 2024

Choose a reason for hiding this comment

NullWanderer Apr 3, 2024

Choose a reason for hiding this comment

deltanedas Apr 4, 2024

Choose a reason for hiding this comment

NullWanderer commented Apr 3, 2024

NullWanderer commented Apr 3, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 18, 2024

ghost commented Sep 2, 2024

NullWanderer commented Apr 1, 2024 •

edited by ghost

Loading

github-actions bot commented Apr 1, 2024 •

edited

Loading