Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ifriit ghost role showing up as unknown #1055

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Adrian16199
Copy link
Contributor

About the PR

Fixes the hijacked #289

Why / Balance

Aparently, ghosting from an ifriit, caused the ghost role to become "unknown", this fixes it.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@github-actions github-actions bot added the Changes: YML Changes any yml files label Apr 3, 2024
@Adrian16199
Copy link
Contributor Author

Adrian16199 commented Apr 3, 2024

Zrzut ekranu 2023-05-18 190842
What (why did it fail the test debug)

@NullWanderer NullWanderer changed the title Fixes the hijacked issue Fixe Ifriit ghost role showing up as unknown Apr 3, 2024
@NullWanderer NullWanderer changed the title Fixe Ifriit ghost role showing up as unknown Fix Ifriit ghost role showing up as unknown Apr 3, 2024
@Guess-My-Name
Copy link
Contributor

Maybe it's the quotation marks that make something not right?
Also, you forgot to add rules, just copy paste lines 11,12,13 from >here<.

@Adrian16199
Copy link
Contributor Author

Would be an odd error due to the:
image
since laika has this.

@Adrian16199
Copy link
Contributor Author

Nevermind, null redid the checks and its aparently fine now, yey.

@IamVelcroboy IamVelcroboy merged commit 8eb4ea3 into DeltaV-Station:master Apr 10, 2024
12 checks passed
@Adrian16199 Adrian16199 deleted the ifriit-fix branch April 12, 2024 08:37
nearlyNonexistent referenced this pull request in nearlyNonexistent/Horizon-Station Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants