Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shuttle structure construction #1069

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

IamVelcroboy
Copy link
Member

@IamVelcroboy IamVelcroboy commented Apr 9, 2024

About the PR

Title + I removed some unnecessary Nyano references and comp-part duplications.

Why / Balance

System was pulled from Nyano but was incomplete and not updated with the fixes/edits from upstream. This created visual glitches and other wonkiness.

Changelog
🆑 Velcroboy

  • fix: Fixed shuttle wall deconstruction causing visual glitches!

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

RSI Diff Bot; head commit c4b4b68 merging into 6030f1f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Walls/shuttle.rsi

State Old New Status
shuttle_construct-0 Added
shuttle_construct-1 Added
shuttle_construct-2 Added
shuttle_construct-3 Added
shuttle_construct-4 Added
shuttle_construct-5 Added

@NullWanderer
Copy link
Contributor

We should replace these with whats on upstream

@IamVelcroboy
Copy link
Member Author

We should replace these with whats on upstream

That's exactly what this does

Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IamVelcroboy IamVelcroboy merged commit f5c7808 into DeltaV-Station:master Apr 10, 2024
15 checks passed
nearlyNonexistent referenced this pull request in nearlyNonexistent/Horizon-Station Apr 14, 2024
Co-authored-by: Velcroboy <velcroboy333@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants