-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shipyard rewrite/port #1171
shipyard rewrite/port #1171
Conversation
UI code got changed with the incoming merge, this will have to wait until after that is merged |
yep has a comment to update when merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna request 2 things here.
An arbitrage test, and a test that makes sure shuttles are valid (if there isn't already a test that does this.)
as in having != 1 grids? shuttles being loadable is tested already |
Stuff like that, yes. Along with making sure there's a shuttle console, and at least 1 dock |
Shipyard isn't meant to be obtainable, im pretty sure it's one of the consoles meant to be mapped into bridge, might add it to shuttle creation though |
yeah mapping being in locker or research whatevers best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix all arbitrages and I'll approve
Was previously mapped on the bridge |
We should add warp points to all the shuttles too. Can be in a follow up PR but should be done eventually. |
When thats done, it should be added to the tests too. Ensure the shuttles always have a warp point |
But should probably be a seperate pr lol |
test itself has dirty disposing but theres no arbitrage, can fix test now or later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick, lgtm otherwise
About the PR
port shipyard from pre rebase, but:
once it enters ftl space the temporary map gets deleted
currently unobtainable i forgor how its meant to be gotten
also someone needs to look over the prices a lot of them seem insanely high, maybe copy frontier
Media
temp map gets created then deleted after it ftls
ship automatically docks, no stations have the funny docks mapped so it will basically be random
ships have name and a random id similar to frontier
Ship changes
all ships:
invalid
etc from the ymlbarge:
helix:
pulse: