Administrative Assistant, a new RP / Support centric "command" role #1207

noctyrnal · 2024-05-15T22:45:46Z

About the PR

Adds the Administrative Assistant role to all stations, acting as both a secretary for command and as a worker on the bridge, answering faxes , grabbing coffees for command members and so on. Intended to support command members in more menial tasks, and to provide unique RP circumstances.

Why / Balance

Makes command's life a bit easier to have a person dedicated to helping them do the small things

Technical details

None

Media

[ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

add: Added the Administrative Assistant Role! Assist command in their day-to-day activities, grab the captain a coffee, answer faxes in the bridge!

oops!

deltav-mapserver · 2024-05-15T22:46:54Z

This PR contains new or changed maps:

arena.yml
asterisk.yml
edge.yml
hammurabi.yml
hive.yml
lighthouse.yml
pebble.yml
shoukou.yml
submarine.yml
tortuga.yml

Maps are being rendered. This comment will be updated if rendering them is done.
05/15/24 22:46

github-actions · 2024-05-15T22:48:07Z

RSI Diff Bot; head commit 2dfd51c merging into 48397c8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/admin_assistant.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/admin_assistant.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State	Old	New	Status
AdminAssistant			Added

Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State	Old	New	Status
pda-admin-assistant			Added

Resources/Textures/DeltaV/Objects/Misc/id_cards.rsi

State	Old	New	Status
idadminassistant			Added

Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State	Old	New	Status
stamp-admin-assistant			Added

Resources/Textures/Markers/jobs.rsi

State	Old	New	Status
adminassistant			Added

Resources/Textures/Objects/Misc/bureaucracy.rsi

State	Old	New	Status
paper_stamp-admin-assistant			Added

Edit: diff updated after 2dfd51c

NullWanderer

Why does this remove courier localisation?

You shouldn't be editing maps in the same pr that introduces something, mappers should do that on their own, or if they're unavailable, it should be a seperate pr.

noctyrnal · 2024-05-15T22:49:07Z

Why does this remove courier localisation?

Probably me misreading one of the changes in master and assuming I accidentally deleted something, I'll go undo that now

You shouldn't be editing maps in the same pr that introduces something, mappers should do that on their own, or if they're unavailable, it should be a seperate pr.

Noted

NullWanderer · 2024-05-15T22:52:40Z

I see more problems, but I'll do a bigger review tomorrow

noctis makes yet another oopsie, I'll revert / fix whatevers needed after review

DangerRevolution

I'm also going to politely beg for you to add localistations for all the new entities <3

Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/backpack.yml

Resources/Prototypes/DeltaV/Entities/Objects/Devices/pda.yml

Resources/Prototypes/DeltaV/Entities/Objects/Misc/identification_cards.yml

Resources/Prototypes/DeltaV/Roles/Jobs/Command/admin_assistant.yml

Resources/Prototypes/DeltaV/Roles/play_time_trackers.yml

Resources/Prototypes/Roles/Jobs/departments.yml

NullWanderer · 2024-05-15T23:17:13Z

Localized entities are not a requirement and make editing more difficult. It should only be reserved for non English codebases.

DangerRevolution · 2024-05-15T23:19:43Z

Localized entities are not a requirement and make editing more difficult. It should only be reserved for non English codebases.

would be nice for some of our downstreams that aren't English :)

Timemaster99 · 2024-05-16T00:04:53Z

By name, this is an assistant role, similar to technical assistant, research assistant, security cadet and medical intern. New players will see this and think of it as a decent role to get them used to the pressures of command before entering a position of responsibility.
That's why I motion to remove the command time requirement and whitelist. For the whitelist, I believe the purpose of that system is to keep the most influential roles to a higher standard. By itself, this role has no influence and depends on assignments from command to enact any authority (as you will not see anyone respecting the will of someone with "assistant" in their job name). As for the command time, it's unnecessary to require the role with the lowest authority in command to be in the upper echelon of experience for command roles, especially because of how attractive this role is to newer players looking to learn command.
I understand that the requirements are likely a result of the accesses granted to the role. I agree with Danger that these should be limited. Chief Engineer could benefit from AA to repair station-threatening breaches, but they are still not afforded that much power. Command access is all that's required for this role to operate normally, and since that access gives them permission to call the shuttle and make announcements, the 30 hour overall requirement is equitable. Command requirements already average ~30 hours playtime, so this is definitely enough to prevent raiders and uncommitted players.
Aside from that, I think a role to help transition players into command is a great addition. It will help new players attach to a command member of choice and learn from them, while also giving some nice interactions and roleplay for command members themselves. Great job on this PR

github-actions · 2024-05-18T12:39:49Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Also fixes the missing courier localisation because I was dumb

noctyrnal · 2024-06-03T14:27:37Z

I plan on renaming this to Administrative Secretary to further get the point across that this is a support command role and not a command role designed for learning the aspects of command. I'll do this once I have everything all done as per the final review.

I accidentally left in 2 empty groups

DangerRevolution

looks good; only thing I'd say is to add empty lines at the bottom of each file for consistency; and to localise some of the new entities but those are both up to you.

Resources/Locale/en-US/deltav/job/job-description.ftl

Resources/Locale/en-US/deltav/job/job-names.ftl

Resources/Locale/en-US/deltav/job/job-supervisors.ftl

Resources/Locale/en-US/deltav/paper/stamp-component.ftl

Resources/Locale/en-US/deltav/preferences/loadout-groups.ftl

Resources/Prototypes/DeltaV/Entities/Markers/Spawners/jobs.yml

Resources/Prototypes/DeltaV/Entities/Objects/Devices/pda.yml

Resources/Prototypes/DeltaV/Entities/Objects/Misc/identification_cards.yml

Resources/Prototypes/DeltaV/Entities/Objects/Misc/rubber_stamp.yml

Resources/Prototypes/DeltaV/Loadouts/Jobs/Command/admin_assistant.yml

Added empty lines to ends of files, moved some ftl stuff to delta v files, added nospawn to marker and rubber stamp.

NullWanderer · 2024-06-03T17:33:41Z

and to localise some of the new entities

You have already been informed we don't do this several times. If you continue to give our contributors bad advice like this, you may be banned from the repository.

NullWanderer

I still hate how stamps must be in the same upstream file. I'll look into if this is something we can change sometime

Resources/Prototypes/DeltaV/Entities/Markers/Spawners/jobs.yml

Resources/Prototypes/DeltaV/Entities/Objects/Misc/rubber_stamp.yml

Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/backpack.yml

github-actions · 2024-06-07T13:32:52Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

noctyrnal · 2024-06-11T14:51:12Z

Should be all ready for a review now, merged to master and fixed the conflicts

NullWanderer

The code changes look good, but this is going to go through more discussion first. Do not merge until that is done

noctyrnal · 2024-06-12T17:57:56Z

we're so back secretary bros

sword-of-stabbing · 2024-06-12T21:13:02Z

This would probably be the command role I would play the most. Head of Paperwork, basically. I love bureaucracy.

Timemaster99 · 2024-06-12T23:42:57Z

This would probably be the command role I would play the most. Head of Paperwork, basically. I love bureaucracy.

HoP in shambles

github-actions · 2024-06-14T12:33:15Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

TadJohnson00 · 2024-09-05T18:44:23Z

Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/backpack.yml

+  parent: ClothingBackpack
+  id: ClothingBackpackAdminAssistantFilled
+  name: administrative assistant's backpack
+  description: Its a backpack build for carrying paper.


*"It's", *"built"

TadJohnson00 · 2024-09-05T18:44:51Z

Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml

+  parent: ClothingBackpackDuffel
+  id: ClothingBackpackDuffelAdminAssistantFilled
+  name: administrative assistant's duffel bag
+  description: Its a duffel bag build for carrying paper.


*"It's", *"built"

TadJohnson00 · 2024-09-05T18:45:05Z

Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/satchel.yml

+  parent: ClothingBackpackSatchel
+  id: ClothingBackpackSatchelAdminAssistantFilled
+  name: administrative assistant's satchel
+  description: Its a satchel build for carrying paper.


*"It's", *"built"

TadJohnson00 · 2024-09-05T18:45:22Z

Resources/Prototypes/DeltaV/Entities/Clothing/Ears/headset_alt.yml

+  - type: Sprite
+    sprite: Clothing/Ears/Headsets/command.rsi
+  - type: Clothing
+    sprite: Clothing/Ears/Headsets/command.rsi


new line here would be great x3

TadJohnson00 · 2024-09-05T18:48:25Z

Resources/Prototypes/DeltaV/Loadouts/loadout_groups.yml

+  name: loadout-group-admin-assistant-outerclothing
+  minLimit: 0
+  loadouts:
+  - CaptainWintercoat


pretty please change this out for something else. duravest would work fine for now until your or I get to spriting a dedicated coat

TadJohnson00 · 2024-09-05T18:50:06Z

Resources/Prototypes/DeltaV/Roles/Jobs/Command/admin_assistant.yml

+  description: job-description-admin-assistant
+  playTimeTracker: JobAdminAssistant
+  requirements:
+    - !type:DepartmentTimeRequirement


1984 the command time requirement

TadJohnson00 · 2024-09-05T18:54:57Z

Resources/Prototypes/DeltaV/Roles/Jobs/Command/admin_assistant.yml

+    - !type:DepartmentTimeRequirement
+      department: Command
+      time: 21600 # 6 hours
+    - !type:OverallPlaytimeRequirement 


set this to twenty five hours (90000) pretty please

TadJohnson00 · 2024-09-05T18:55:44Z

Resources/Prototypes/DeltaV/Roles/Jobs/Command/admin_assistant.yml

+    shoes: ClothingShoesBootsLaceup
+    belt: BoxFolderClipboard
+    id: AdminAssistantPDA
+    ears: ClothingHeadsetAltAdminAssistant


TadJohnson00 · 2024-09-05T18:55:51Z

Resources/Prototypes/DeltaV/Roles/play_time_trackers.yml

@@ -15,3 +15,6 @@

 - type: playTimeTracker
  id: JobCourier
+
+- type: playTimeTracker
+  id: JobAdminAssistant


TadJohnson00 · 2024-09-05T18:57:06Z

Resources/Textures/DeltaV/Objects/Devices/pda.rsi/pda-admin-assistant.png

can we get a new PDA sprite for this pretty please??? >.<

noctyrnal added 7 commits May 15, 2024 19:10

file move

ac7cd64

stamp and id

d3213d5

trying to figure out loadout yml

73cd660

fixes loadout and a few borked ftls

a60726a

Accidentally deleted courier spawn

f6ce8cd

oops!

Adds spawner to every map + updates prototypes

95c83c4

Merge branch 'master' into admin-assist

d138aec

noctyrnal requested a review from IamVelcroboy as a code owner May 15, 2024 22:46

github-actions bot added the Status: Needs Review label May 15, 2024

github-actions bot added Changes: YML Changes any yml files Changes: Map Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels May 15, 2024

NullWanderer requested changes May 15, 2024

View reviewed changes

Reverts Spawns + Fixes mail courier somewhat

14da00b

noctis makes yet another oopsie, I'll revert / fix whatevers needed after review

DangerRevolution reviewed May 15, 2024

View reviewed changes

github-actions bot added the Status: Merge Conflict Fix your PR! label May 18, 2024

merge master

e0b34c2

github-actions bot removed the Status: Merge Conflict Fix your PR! label May 25, 2024

noctyrnal added 2 commits May 28, 2024 16:47

Merge branch 'master' into admin-assist

1af9835

Review changes

c1e0641

Also fixes the missing courier localisation because I was dumb

noctyrnal requested a review from NullWanderer May 28, 2024 19:37

Merge branch 'master' into admin-assist

7fecd5c

github-actions bot removed the Status: Merge Conflict Fix your PR! label Jun 3, 2024

removes outdated bureaucracy.rsi content

dcf8abd

Removes outdated parts of role_loadouts

34acb71

I accidentally left in 2 empty groups

noctyrnal requested a review from DangerRevolution June 3, 2024 14:47

DangerRevolution reviewed Jun 3, 2024

View reviewed changes

Review Changes III

42bf0ad

Added empty lines to ends of files, moved some ftl stuff to delta v files, added nospawn to marker and rubber stamp.

noctyrnal requested a review from DangerRevolution June 3, 2024 15:29

NullWanderer requested changes Jun 3, 2024

View reviewed changes

Resources/Prototypes/DeltaV/Entities/Markers/Spawners/jobs.yml Outdated Show resolved Hide resolved

Resources/Prototypes/DeltaV/Entities/Objects/Misc/rubber_stamp.yml Outdated Show resolved Hide resolved

This comment was marked as abuse.

Sign in to view

Timemaster99 reviewed Jun 3, 2024

View reviewed changes

Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/backpack.yml Outdated Show resolved Hide resolved

Reverts nospawns, changes bags

8468231

noctyrnal requested a review from NullWanderer June 6, 2024 20:49

github-actions bot added the Status: Merge Conflict Fix your PR! label Jun 7, 2024

Merge branch 'master' into admin-assist

2dfd51c

github-actions bot removed the Status: Merge Conflict Fix your PR! label Jun 11, 2024

NullWanderer approved these changes Jun 12, 2024

View reviewed changes

NullWanderer added Status: Do Not Merge Don't merge this yet Status: Needs Discussion Must be discussed labels Jun 12, 2024

github-actions bot added the Status: Merge Conflict Fix your PR! label Jun 14, 2024

TadJohnson00 requested changes Sep 5, 2024

View reviewed changes

noctyrnal closed this Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Administrative Assistant, a new RP / Support centric "command" role #1207

Administrative Assistant, a new RP / Support centric "command" role #1207

noctyrnal commented May 15, 2024

deltav-mapserver bot commented May 15, 2024

github-actions bot commented May 15, 2024 •

edited

Loading

NullWanderer left a comment

noctyrnal commented May 15, 2024

NullWanderer commented May 15, 2024

DangerRevolution left a comment

NullWanderer commented May 15, 2024

DangerRevolution commented May 15, 2024

Timemaster99 commented May 16, 2024

github-actions bot commented May 18, 2024

noctyrnal commented Jun 3, 2024

DangerRevolution left a comment

NullWanderer commented Jun 3, 2024

NullWanderer left a comment

This comment was marked as abuse.

github-actions bot commented Jun 7, 2024

noctyrnal commented Jun 11, 2024

NullWanderer left a comment

noctyrnal commented Jun 12, 2024

sword-of-stabbing commented Jun 12, 2024

Timemaster99 commented Jun 12, 2024

github-actions bot commented Jun 14, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

TadJohnson00 Sep 5, 2024

Administrative Assistant, a new RP / Support centric "command" role #1207

Administrative Assistant, a new RP / Support centric "command" role #1207

Conversation

noctyrnal commented May 15, 2024

About the PR

Why / Balance

Technical details

Media

Breaking changes

deltav-mapserver bot commented May 15, 2024

github-actions bot commented May 15, 2024 • edited Loading

NullWanderer left a comment

Choose a reason for hiding this comment

noctyrnal commented May 15, 2024

NullWanderer commented May 15, 2024

DangerRevolution left a comment

Choose a reason for hiding this comment

NullWanderer commented May 15, 2024

DangerRevolution commented May 15, 2024

Timemaster99 commented May 16, 2024

github-actions bot commented May 18, 2024

noctyrnal commented Jun 3, 2024

DangerRevolution left a comment

Choose a reason for hiding this comment

NullWanderer commented Jun 3, 2024

NullWanderer left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

github-actions bot commented Jun 7, 2024

noctyrnal commented Jun 11, 2024

NullWanderer left a comment

Choose a reason for hiding this comment

noctyrnal commented Jun 12, 2024

sword-of-stabbing commented Jun 12, 2024

Timemaster99 commented Jun 12, 2024

github-actions bot commented Jun 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 15, 2024 •

edited

Loading