Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased security PDAs' cartridge slots by 2 #1266

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Remuchi
Copy link
Contributor

@Remuchi Remuchi commented May 28, 2024

About the PR

Increased cartridge slots for all security PDAs to compensate for SecWatch and CrimeAssist. Now security can once again install other programs.

Closes #1259

Why / Balance

Couldn't install LogProbe or any other program on any security PDA after the addition of SecWatch and CrimeAssist. Huge disadvantage for detective.

🆑

  • tweak: Cartridge slots in all security PDAs were increased by 2 to compensate for the addition of SecWatch and CrimeAssist.

@github-actions github-actions bot added the Changes: YML Changes any yml files label May 28, 2024
@Colin-Tel
Copy link
Contributor

I wonder if it'd instead be better to attach the

  - type: CartridgeLoader # DeltaV - Crime Assist + SecWatch, increased diskSpace by 2 to fit them
    diskSpace: 7

to BasePDA since it'd cover everything.

@Remuchi
Copy link
Contributor Author

Remuchi commented May 28, 2024

I had a thought about it but didn't really wanna go into changing BasePDA as this problem only appears in security PDAs. Changing it to all PDAs is a balance thing I suppose (tho we don't really have enough cartridges so it would matter anyway)

@WarMechanic
Copy link
Contributor

Why should security PDA's specifically have more cartridges? If anything, epistemics PDA's would see future development in PDA apps so it doesn't really make sense, as opposed to BasePDA.

Copy link
Contributor

@NullWanderer NullWanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR body is too lacking. This absolutely needs screenshots in game to show this doesn't cause issues. If anything, the increase could probably be upstreamed too

@Remuchi
Copy link
Contributor Author

Remuchi commented May 28, 2024

I'll add screenshots a bit later.
About the increased limit, the problem described in the issue only happens with DeltaV security PDAs since DeltaV modifies starting programs in them. It doesn't affect the overall limit as security can install only 2 more programs on their PDAs as any other PDA on the station.
Although maybe the epi PDAs should have increased limit as well

@Remuchi
Copy link
Contributor Author

Remuchi commented May 28, 2024

image

New limit is right enough so it fits without scrolling

@NullWanderer NullWanderer merged commit 5885e17 into DeltaV-Station:master Jun 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detective can't install LogProbe after SecWatch was added
4 participants