Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return dragons #1308

Closed
Closed

Conversation

Mnemotechnician
Copy link
Contributor

About the PR

Returns the space dragon event and fixes the devour system

Why / Balance

Because more time was wasted discussing the removal of one of the few midround antags than it took me to fix what caused the removal in the first place.

As I was told, the reason was round-removal of eaten bodies.

Technical details

Made DevourSystem empty the stomach container of the Devourer when it's being gibbed (butchering includes gibbing) and reverted the PR that removed the dragon spawn.

Media

aAAAAAAAAAAAAAAAAA.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog
🆑

  • fix: The space dragon event is back!
  • fix: Butchering or gibbing a space dragon will now properly drop the bodies it has eaten.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files labels Jun 5, 2024
@Lyndomen
Copy link
Member

Lyndomen commented Jun 5, 2024

Excellent, just what we needed. Thank you for the fix.

@NullWanderer
Copy link
Contributor

This should be done upstream

@Lyndomen
Copy link
Member

Lyndomen commented Jun 7, 2024

Mnemotechnician, are you interested in submitting this fix upstream?

@Mnemotechnician
Copy link
Contributor Author

No, and I think you see why I didn't want to bother in the first place.

@Mnemotechnician Mnemotechnician deleted the fix/vore branch June 7, 2024 14:01
@Lyndomen
Copy link
Member

Lyndomen commented Jun 7, 2024

With your permission I will upstream this under their license. Just let me know- thanks!

@Mnemotechnician
Copy link
Contributor Author

feel free to, I don't care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants