Senior ID cards get a custom job name: Attempt 3

[WarMechanic]

About the PR

Taking the Senior ID card for jobs that support it will change your job title and icon to match that of the senior role.

My advice to heads of staff: Treat your seniors like they have 60 hours of playtime. Delegate them to teach recruits properly, do things that are hard and condemn them harshly for incompetence.

Why / Balance

Fixes #1263

Technical details

This solution reverts #1218 and moves most of the job name changing logic to take place in C.S/.../GameTicker.Spawning to catch when the player spawns both at round-start and the middle of the round. Various overrides in a few scripts check for VirtualJobName/Icon in a JobComponent.
No longer uses job prototypes like in Attempt 2.

Media

https://youtu.be/_YaD1ESBiwA

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

• fix: Fixed senior job titles not displaying properly

[NullWanderer]

I know I didn't either, but these should really be using localized job names. Looks good besides that

[github-actions]

RSI Diff Bot; head commit 709d57d merging into 09d897e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Decals/bricktile.rsi

State	Old	New	Status
dark_box			Added
dark_corner_ne			Added
dark_corner_nw			Added
dark_corner_se			Added
dark_corner_sw			Added
dark_end_e			Added
dark_end_n			Added
dark_end_s			Added
dark_end_w			Added
dark_inner_ne			Added
dark_inner_nw			Added
dark_inner_se			Added
dark_inner_sw			Added
dark_line_e			Added
dark_line_n			Added
dark_line_s			Added
dark_line_w			Added
steel_box			Added
steel_corner_ne			Added
steel_corner_nw			Added
steel_corner_se			Added
steel_corner_sw			Added
steel_end_e			Added
steel_end_n			Added
steel_end_s			Added
steel_end_w			Added
steel_inner_ne			Added
steel_inner_nw			Added
steel_inner_se			Added
steel_inner_sw			Added
steel_line_e			Added
steel_line_n			Added
steel_line_s			Added
steel_line_w			Added
white_box			Added
white_corner_ne			Added
white_corner_nw			Added
white_corner_se			Added
white_corner_sw			Added
white_end_e			Added
white_end_n			Added
white_end_s			Added
white_end_w			Added

[WarMechanic]

i think i bunged something up, i had to pull my git files while working here in america.

[WarMechanic]

all the errors have been fixed, and i have playtested the solution and found everything to be working. i think its good to go