Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homerun bat 2 #1476

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Homerun bat 2 #1476

merged 4 commits into from
Jul 22, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Jul 9, 2024

About the PR

revival of #823 with small balance changes:

  • nerfed its structural damage from 15 to 10
  • made 16 TC since its not as op and so more roles can buy it not just passenger

also just inherits baseball bat now to not copy paste everything

Why / Balance

it was too op for breaking down doors and shit now its more a funny spaceman launcher

Media

03:28:26
03:24:47

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑 musicmanvr

  • add: Added the Home Run Bat for Syndicate operatives. Send your foes flying!

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

RSI Diff Bot; head commit cbc8ea3 merging into 82c3915
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Melee/home_run_bat.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after cbc8ea3

@dvir001
Copy link
Contributor

dvir001 commented Jul 14, 2024

Why do I feel this should have the G.O.R.I.L.L.A. gauntlet unanchorOnHit on it?

@deltanedas
Copy link
Member Author

oh real that was never added

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my look at this, this seems normal, and fine to merge. Didn't see any mistakes, everything's in DeltaV folders, all that good stuff. One day I should actually PR a baseball so the existence of baseball bats makes sense though that's a note to self

Dvir poses a good point about that component, I'd love to fling Butlertron across the room with this but what's already here is alright.

@deltanedas
Copy link
Member Author

baseball

already exists upstream just nothing uses it + you cant hit it with bat

@deltanedas
Copy link
Member Author

also the reason it cant unanchor on hit is you could use it to troll glimmer probers at 500

@deltanedas deltanedas merged commit 24ece9b into DeltaV-Station:master Jul 22, 2024
13 checks passed
@deltanedas deltanedas deleted the homerun-bat-2 branch July 22, 2024 19:20
@ghost
Copy link

ghost commented Jul 23, 2024

baseball

already exists upstream just nothing uses it + you cant hit it with bat

Messed up.

@dvir001
Copy link
Contributor

dvir001 commented Jul 23, 2024

also the reason it cant unanchor on hit is you could use it to troll glimmer probers at 500

https://github.com/new-frontiers-14/frontier-station-14/pull/1368/files

Could consider adding a Whitelist / Blacklist on the unanchorOnHit so it can be added without too many issues.

@musicmanvr
Copy link
Contributor

this pleases me

VMSolidus pushed a commit to Simple-Station/Einstein-Engines that referenced this pull request Aug 12, 2024
# Description

Adds the home run bat as a new item for traitors, a new traitor weapon
that knocks targets back significantly.

The home run bat has the same Nyanocombat stats as the baseball bat,
with differences: damage has been reduced by around 25%, same as the
baseball bat, and the Stamina damage on power attacks is 25.

Originally made for Delta-V
(DeltaV-Station/Delta-v#1476)

## Media

<details>


![image](https://github.com/user-attachments/assets/3502145f-cae2-4ce0-9ae2-a0f2eeb48c8b)

![image](https://github.com/user-attachments/assets/f508a367-d2bb-4283-bd47-de4b4b272637)

</details>

## Changelog

:cl: musicmanvr
- add: Added the Home Run Bat for Syndicate operatives. Send your foes
flying!

---------

Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Aug 12, 2024
# Description

Adds the home run bat as a new item for traitors, a new traitor weapon
that knocks targets back significantly.

The home run bat has the same Nyanocombat stats as the baseball bat,
with differences: damage has been reduced by around 25%, same as the
baseball bat, and the Stamina damage on power attacks is 25.

Originally made for Delta-V
(DeltaV-Station/Delta-v#1476)

## Media

<details>


![image](https://github.com/user-attachments/assets/3502145f-cae2-4ce0-9ae2-a0f2eeb48c8b)

![image](https://github.com/user-attachments/assets/f508a367-d2bb-4283-bd47-de4b4b272637)

</details>

## Changelog

:cl: musicmanvr
- add: Added the Home Run Bat for Syndicate operatives. Send your foes
flying!

---------

Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
tmcqueen pushed a commit to tmcqueen/Syndicate-Station that referenced this pull request Aug 24, 2024
# Description

Adds the home run bat as a new item for traitors, a new traitor weapon
that knocks targets back significantly.

The home run bat has the same Nyanocombat stats as the baseball bat,
with differences: damage has been reduced by around 25%, same as the
baseball bat, and the Stamina damage on power attacks is 25.

Originally made for Delta-V
(DeltaV-Station/Delta-v#1476)

## Media

<details>


![image](https://github.com/user-attachments/assets/3502145f-cae2-4ce0-9ae2-a0f2eeb48c8b)

![image](https://github.com/user-attachments/assets/f508a367-d2bb-4283-bd47-de4b4b272637)

</details>

## Changelog

:cl: musicmanvr
- add: Added the Home Run Bat for Syndicate operatives. Send your foes
flying!

---------

Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants