Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprite the Typewriter. #1791

Merged
4 commits merged into from
Sep 18, 2024
Merged

Conversation

TadJohnson00
Copy link
Contributor

@TadJohnson00 TadJohnson00 commented Sep 11, 2024

About the PR

Resprites the Typewriter.

Why / Balance

Because it was one of my early sprites and is long due for an improvement.

Technical details

n/a

Media

image
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

n/a
Changelog

Does this need a CL?

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Sep 11, 2024
@TadJohnson00
Copy link
Contributor Author

Will get sprites in a sec.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

RSI Diff Bot; head commit 6687967 merging into 39158b5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/SMGs/typewriter.rsi

State Old New Status
base Modified
bolt-open Modified
equipped-BACKPACK Modified
icon Modified
inhand-left Modified
inhand-right Modified
mag-0 Modified
mag-1 Removed
mag0-inhand-left Removed
mag0-inhand-right Removed
equipped-SUITSTORAGE Added
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after 6687967

@IamVelcroboy
Copy link
Member

Haha, before I looked at the files, I was like, "we have a typewriter!?!?"

@TadJohnson00 TadJohnson00 marked this pull request as ready for review September 11, 2024 00:43
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks kind of funny on the front-equipped sprite thing, otherwise, miiiiight be fine?

@ghost ghost merged commit 75b8bc1 into DeltaV-Station:master Sep 18, 2024
12 checks passed
@TadJohnson00 TadJohnson00 deleted the respriteballistics branch September 28, 2024 10:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants