Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "The Resprite: Diagonal Reinforced Wall, Greyscale Decal Cleanup, Secret Doors" #1924

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

MilonPL
Copy link
Contributor

@MilonPL MilonPL commented Sep 27, 2024

About the PR

Reverts #1842

Why / Balance

Looks like it was merged without approval from velcro or anyone going over the yaml
Maintaining this is hellish (because frontier code) and I kinda gave up on fixing all of the issues + the sprites collide with ours anyways. The secrets door are buggy when being opened, and you can spot them because of the sprite anyways. That PR probably should've been split instead of cherry picking and fixing things at once.
If someone wants to pick the latest changes from frontier and resprite the diagonal walls, this could be brought back.

image
image

@MilonPL MilonPL requested review from IamVelcroboy and a team as code owners September 27, 2024 10:42
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed Status: Needs Review labels Sep 27, 2024
Copy link
Contributor

RSI Diff Bot; head commit 91a8438 merging into 6a80988
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Decals/Overlays/greyscale.rsi

State Old New Status
checkerNESW Removed
checkerNWSE Removed
diagonal Removed
diagonal_checker_a Removed
diagonal_checker_b Removed
fulltile_overlay Removed
halftile_overlay Removed
halftile_overlay_180 Removed
halftile_overlay_270 Removed
halftile_overlay_90 Removed
quartertile_overlay Removed
quartertile_overlay_180 Removed
quartertile_overlay_270 Removed
quartertile_overlay_90 Removed
threequartertile_overlay Removed
threequartertile_overlay_180 Removed
threequartertile_overlay_270 Removed
threequartertile_overlay_90 Removed

Resources/Textures/_NF/Structures/Doors/secret_door_reinforced.rsi

State Old New Status
assembly Removed
closed Removed
closing Removed
open Removed
opening Removed

Resources/Textures/_NF/Structures/Doors/secret_door_shuttle.rsi

State Old New Status
assembly Removed
closed Removed
closing Removed
open Removed
opening Removed

Resources/Textures/_NF/Structures/Doors/secret_door_uranium.rsi

State Old New Status
assembly Removed
closed Removed
closing Removed
open Removed
opening Removed

Resources/Textures/_NF/Structures/Doors/secret_door_wood.rsi

State Old New Status
assembly Removed
closed Removed
closing Removed
open Removed
opening Removed

Resources/Textures/_NF/Structures/Walls/solid_reinforced_diagonal.rsi

State Old New Status
state0 Removed
state1 Removed

Resources/Textures/_NF/Structures/Walls/uranium_diagonal.rsi

State Old New Status
state0 Removed
state1 Removed

Resources/Textures/_NF/Structures/Walls/wood_diagonal.rsi

State Old New Status
state0 Removed
state1 Removed

@Colin-Tel Colin-Tel merged commit 7a07bde into master Sep 27, 2024
16 checks passed
@MilonPL MilonPL deleted the revert-1842-finishing-the-resprite branch September 27, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants