untroll glimmermobspawnrule #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Changes: C#
deltanedas
requested changes
Oct 7, 2024
Content.Server/DeltaV/StationEvents/Events/GlimmerMobSpawnRule.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/StationEvents/Events/GlimmerMobSpawnRule.cs
Outdated
Show resolved
Hide resolved
|
test fail fake but there's no way we got rate limited |
|
as in pass station as argument to GetCoords |
i don't think it needs to now, since it just checks whether the owning station is valid? |
|
wouldnt handle multistation properly, just have the event pick 1 station at the start and use that for all rolls so its futureproof |
|
ok got it i think |
deltanedas
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
changes it so that GlimmerMobSpawn will no longer try spawning glimmer creatures outside the station
Why / Balance
annoying AS FUCK
Technical details
blah code is clear enough but it does the same thing as the RandomSpawnRule basically
Requirements
Breaking changes
Changelog
🆑