erase verb for all entities #2032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Changes: C#
|
I hate this entire code, I might want to move the popup to a separate method and turn change the text based on if the target has a MindContainer or not. It's pissing me off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
adds the erase verb to all entities
Why / Balance
funny
Technical details
the erase method is so fucking shit i need to refactor it upstream at some point but review hell
i commented it as best as I could but big code change so
split into two methods, one for NetUserId and another one for EntityUid
the NetUserId one calls the base EntityUid method and does some extra shit like nuking messages and spawning an observer
ideally this would all be in helper methods instead of whatever fever dream this is
AdminVerbSystem modified to add the erase verb for entities without a mind
Contents of this entire PR are dual-licensed under MIT, forks that are not AGPL are free to use them.
Media
Breaking changes
backwards compatible
trust
Changelog
🆑
DELTAVADMIN: