Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Declaration of War #27

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

Tryded
Copy link
Contributor

@Tryded Tryded commented Sep 17, 2023

Removes the ability for nuclear operatives to declare war.

About the PR

Takes away the commander's declaration of war remote. Still can get spawned by admeme.

Why / Balance

WarOps are usually just LRP, turning into a deathmatch between the station and nuclear operatives.

Technical details

Edited the commander's loadout to not have the Declaration of War.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Removes the ability for nuclear operatives to declare war.
@github-actions github-actions bot added Changes: Sprites Changes: YML Changes any yml files labels Sep 17, 2023
@github-actions
Copy link
Contributor

RSI Diff Bot; head commit 94782fa merging into e43ca8c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/declaration_of_war.rsi

State Old New Status
declarator Removed

@VMSolidus
Copy link
Contributor

It would probably be best to only remove it from starting equipment, but not from the game's code. So as to prevent potential merge conflicts.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 17, 2023

Alright, I'll try to add back the files.

@@ -135,8 +135,6 @@
pocket1: DoubleEmergencyOxygenTankFilled
pocket2: BaseUplinkRadio40TC
belt: ClothingBeltMilitaryWebbing
inhand:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All you would need is to comment out those two lines and keep the rest.
This technically allows the least amount of conflicts and admins can still spawn them in if they want to for events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point is still valid. Don't remove the lines, just comment them out.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 17, 2023

Is there an easy way to remove some of the changes?

@Tryded
Copy link
Contributor Author

Tryded commented Sep 17, 2023

That should have done it.

@@ -135,8 +135,6 @@
pocket1: DoubleEmergencyOxygenTankFilled
pocket2: BaseUplinkRadio40TC
belt: ClothingBeltMilitaryWebbing
inhand:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point is still valid. Don't remove the lines, just comment them out.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 18, 2023

I have figured out what does commenting out mean, it has been done.

Colin-Tel
Colin-Tel previously approved these changes Sep 19, 2023
@Colin-Tel Colin-Tel enabled auto-merge (squash) September 19, 2023 14:10
@@ -135,8 +135,8 @@
pocket1: DoubleEmergencyOxygenTankFilled
pocket2: BaseUplinkRadio40TC
belt: ClothingBeltMilitaryWebbing
inhand:
right hand: NukeOpsDeclarationOfWar
#inhand:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the reason behind the comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair enough.

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

Signed-off-by: Tryded <139474617+Tryded@users.noreply.github.com>
@Tryded
Copy link
Contributor Author

Tryded commented Sep 19, 2023

I have finally (maybe) finished editing 2 lines of code

@Colin-Tel Colin-Tel enabled auto-merge (squash) September 21, 2023 20:03
@Colin-Tel Colin-Tel merged commit a95d14e into DeltaV-Station:master Sep 21, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants