-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Declaration of War #27
Remove Declaration of War #27
Conversation
Removes the ability for nuclear operatives to declare war.
It would probably be best to only remove it from starting equipment, but not from the game's code. So as to prevent potential merge conflicts. |
Alright, I'll try to add back the files. |
@@ -135,8 +135,6 @@ | |||
pocket1: DoubleEmergencyOxygenTankFilled | |||
pocket2: BaseUplinkRadio40TC | |||
belt: ClothingBeltMilitaryWebbing | |||
inhand: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All you would need is to comment out those two lines and keep the rest.
This technically allows the least amount of conflicts and admins can still spawn them in if they want to for events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This point is still valid. Don't remove the lines, just comment them out.
Is there an easy way to remove some of the changes? |
That should have done it. |
@@ -135,8 +135,6 @@ | |||
pocket1: DoubleEmergencyOxygenTankFilled | |||
pocket2: BaseUplinkRadio40TC | |||
belt: ClothingBeltMilitaryWebbing | |||
inhand: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This point is still valid. Don't remove the lines, just comment them out.
I have figured out what does commenting out mean, it has been done. |
@@ -135,8 +135,8 @@ | |||
pocket1: DoubleEmergencyOxygenTankFilled | |||
pocket2: BaseUplinkRadio40TC | |||
belt: ClothingBeltMilitaryWebbing | |||
inhand: | |||
right hand: NukeOpsDeclarationOfWar | |||
#inhand: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the reason behind the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
Signed-off-by: Tryded <139474617+Tryded@users.noreply.github.com>
I have finally (maybe) finished editing 2 lines of code |
Removes the ability for nuclear operatives to declare war.
About the PR
Takes away the commander's declaration of war remote. Still can get spawned by admeme.
Why / Balance
WarOps are usually just LRP, turning into a deathmatch between the station and nuclear operatives.
Technical details
Edited the commander's loadout to not have the Declaration of War.
Media
Breaking changes
Changelog