-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paramedic Lockers, Portafibs, and Chemvend Tweaks #53
Conversation
upped jug amounts in each vend to accomodate for their use, and adds all emagged chemicals from the dispenser to them
RSI Diff Bot; head commit 4dff633 merging into 6018cb6 Resources/Textures/DeltaV/Objects/Medical/portafib.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources/Prototypes/Catalog/VendingMachines/Inventories/medical.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/backpack.yml
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Catalog/Fills/Backpacks/StarterGear/satchel.yml
Show resolved
Hide resolved
Resources/Prototypes/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paramedic is not defined within Content.Shared/Access/Components/IdCardConsoleComponent.cs meaning its an unobtainable access level outside of spawning with it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are valid. Chemvend changes introduce free money for cargo.
Failed NoCargoOrderArbitrage [1 s]
Error Message:
Found arbitrage on CrateVendingMachineRestockChemVend cargo product! Cost is 3820 but sell is 6770!
Expected: less than or equal to 3820
But was: 6770.0d```
removed unnecessary comments (ones indicating a Delta V change while already in the Delta V directory)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We'll just have to see how this affects the balance of things.
Not to be chuggin logs with a meaningless comment but..... I absolutely love this PR. Atleast as a paramedic enjoyer. Being able to carry defibs without it usin half your bag at the cost of power, definitely 10/10 because consequences if you dont pay attention to it as balance, givin paramedics additional access durin skeleton crew, absolutely 10/10 because i want to be able to paramed but also get chems if im alone at medical without CMO. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me saying the same thing post-merge fix
Looks good! We'll just have to see how this affects the balance of things.
this wont work btw
Fuck it |
The fuck you mean merging failed |
* add paramedic-only access * edit chemvend upped jug amounts in each vend to accomodate for their use, and adds all emagged chemicals from the dispenser to them * add portafib * added comments and tweaked rollerbed * one line comments * Update IdCardConsoleComponent.cs * increase crate price * Comment, misspelling adjustments removed unnecessary comments (ones indicating a Delta V change while already in the Delta V directory) * not all jugs are created equal this wont work btw * chemvend restock price --------- Signed-off-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com> Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
About the PR
Added the content from my previous PRs on the original branch. As a recap of these PRs:
On top of that, I made additional tweaks and fixes to those previous PRs.
portafib.mp4
Tested everything again and it all works.
Technical details
I had to add napalm and ultravasculine bottles to our own code.
Media
Breaking changes
Changelog