Add Anti Anomaly Zone #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Apr 8, 2024
## Mirror of PR #944: [Add Anti Anomaly Zone](DeltaV-Station/Delta-v#944) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/52761126?v=4" width="16"/><a href="https://github.com/rosieposieeee"> rosieposieeee</a> at 2024-03-08 19:07:59 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/52761126?v=4" width="16"/><a href="https://github.com/rosieposieeee"> rosieposieeee</a> at 2024-03-17 13:35:52 UTC</aside> <sup> `7abdf9a19fe59243201336e6b586ee4780a4722e` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > space-wizards/space-station-14#24634 > > Upstream added, then removed this, saying "Remove[d] mapping markers as everything should be ingame entities and this is functioning as an area." They left in the code for downstreams. While an ingame object that can perform this function might be useful, this would be best used for arrivals and inside the atmos gas chambers, to prevent those areas that are supposed to be ungriefed from getting griefed by the game itself. If it were an entity, people would probably game it and move those around, and if it were powered, it would fail at its target function. And regardless, upstream removed this *without adding in that entity to replace it.* > > Additionally, some maps have areas where an anom could fully go crit without anyone noticing and it would never affect anybody... which is really boring, such as this area on arena. I have one or two areas like that on Submarine I'd like to use this for. > >  > </details> Co-authored-by: rosieposie <52761126+rosieposieeee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
space-wizards/space-station-14#24634
Upstream added, then removed this, saying "Remove[d] mapping markers as everything should be ingame entities and this is functioning as an area." They left in the code for downstreams. While an ingame object that can perform this function might be useful, this would be best used for arrivals and inside the atmos gas chambers, to prevent those areas that are supposed to be ungriefed from getting griefed by the game itself. If it were an entity, people would probably game it and move those around, and if it were powered, it would fail at its target function. And regardless, upstream removed this without adding in that entity to replace it.
Additionally, some maps have areas where an anom could fully go crit without anyone noticing and it would never affect anybody... which is really boring, such as this area on arena. I have one or two areas like that on Submarine I'd like to use this for.