Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dei 229 depth average select z or sigma from inputfile #121

Merged
merged 46 commits into from
Aug 7, 2024
Merged

Feature/dei 229 depth average select z or sigma from inputfile #121

merged 46 commits into from
Aug 7, 2024

Conversation

mKlapwijk
Copy link
Collaborator

No description provided.

@mKlapwijk
add file for depth averaging with sigma layers
1c5e15b
@mKlapwijk
working version for sigma layers. DOES not work for z
bc77fee
@mKlapwijk
add test 18, correct paths for test 17
dd98962
@mKlapwijk
rename test 17 reference file
782479c
@mKlapwijk
flake problems
1e58076
@mKlapwijk
more flake problems
1401087
@mKlapwijk
and more flake8
2dcd52a
@mKlapwijk
adding print statements in an attempt to get both to work
66886c2
@mKlapwijk
Merge branch 'feature/DEI-229-depth-averaged-rules-sigma-models' into…
e1d0e44 
… feature/DEI-229-implement-sigma-models-depth-average
@mKlapwijk
Go for the much simpler approach. Let the user specify the layer type
831f072
@mKlapwijk
Update tests to specify layer type
6f3005e
@mKlapwijk
add reference file for test 18
199c43d
@mKlapwijk
add test for parser error
5d285f7
@mKlapwijk
restore accidentally committed file
56c1382
@mKlapwijk
line too long
f1659c7
@mKlapwijk
remove import
8c0e655
@mKlapwijk
update documentation
a357e09
@mKlapwijk
fix unit tests
e36e15e
@mKlapwijk
add layer type to depth average rule data
ca9f8f0
@mKlapwijk
remove check layer function from depth average rule. Use layer type v…
c3c04b7 
…ariable
@mKlapwijk
fix unit tests
4b4fec8
@mKlapwijk
typo
c748e01
@mKlapwijk
move functions out of class
6371010
@mKlapwijk
add layer type to creation
72240b2
@mKlapwijk
remove import
fb84852
CindyvdVries
CindyvdVries approved these changes Aug 5, 2024
View reviewed changes
decoimpact/business/entities/rules/depth_average_rule.py Outdated Show resolved Hide resolved
decoimpact/business/utils/dataset_utils.py Outdated Show resolved Hide resolved
CindyvdVries
CindyvdVries approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@CindyvdVries CindyvdVries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

decoimpact/business/entities/rules/depth_average_rule.py Outdated Show resolved Hide resolved
@mKlapwijk mKlapwijk merged commit cf7d04d into main Aug 7, 2024
1 of 7 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mKlapwijk mKlapwijk deleted the feature/DEI-229-depth-average-select-z-or-sigma-from-inputfile branch August 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CindyvdVries CindyvdVries CindyvdVries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mKlapwijk @CindyvdVries