Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dei 225 filter extremes rule #122

Merged
merged 28 commits into from
Aug 9, 2024
Merged

Feature/dei 225 filter extremes rule #122

merged 28 commits into from
Aug 9, 2024

Commits on Jul 30, 2024

  1. add first setup filter extremes rule

    @CindyvdVries
    CindyvdVries committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    810d229 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/DEI-225-filter-extremes-rule

    @CindyvdVries
    CindyvdVries committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bf63b2c View commit details
    Browse the repository at this point in the history

  3. test on how to implement find_peaks method

    @CindyvdVries
    CindyvdVries committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    64b5e13 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. first working prototype filter extremes rule

    @CindyvdVries
    CindyvdVries committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    34cd5a2 View commit details
    Browse the repository at this point in the history

  2. update working version filter extremes with distance

    @CindyvdVries
    CindyvdVries committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    57aaaf1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. use distance and mask from user input

    @CindyvdVries
    CindyvdVries committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    dde66d7 View commit details
    Browse the repository at this point in the history

  2. implement timeoperationsettings

    @CindyvdVries
    CindyvdVries committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    def238b View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. WIP set up test

    @CindyvdVries
    CindyvdVries committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ac16137 View commit details
    Browse the repository at this point in the history

  2. first Test

    @CindyvdVries
    CindyvdVries committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1d02401 View commit details
    Browse the repository at this point in the history

  3. adding tests for extreme filter rule

    @CindyvdVries
    CindyvdVries committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a3d40a3 View commit details
    Browse the repository at this point in the history

  4. add tests for parser and data object

    @CindyvdVries
    CindyvdVries committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1c01c87 View commit details
    Browse the repository at this point in the history

  5. update documentation

    @CindyvdVries
    CindyvdVries committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7059c7c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/DEI-225-filter-extremes-rule

    @CindyvdVries
    CindyvdVries committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    520fdee View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. acceptance test, mkdocs and clean up

    @CindyvdVries
    CindyvdVries committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a5f702d View commit details
    Browse the repository at this point in the history

  2. update documentation

    @CindyvdVries
    CindyvdVries committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1552018 View commit details
    Browse the repository at this point in the history

  3. pylint

    @CindyvdVries
    CindyvdVries committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c0f0921 View commit details
    Browse the repository at this point in the history

  4. update review part 1

    @CindyvdVries
    CindyvdVries committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    61ce875 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/DEI-225-filter-extremes-rule

    @CindyvdVries
    CindyvdVries committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4607b6d View commit details
    Browse the repository at this point in the history

  6. update review part 2

    @CindyvdVries
    CindyvdVries committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cea14d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. clarify documentation to include local maxima and local minima

    @mKlapwijk
    mKlapwijk committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    59fe32d View commit details
    Browse the repository at this point in the history

  2. change sentence for readability

    @mKlapwijk
    mKlapwijk committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e3690a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. add check on extreme_type options

    @CindyvdVries
    CindyvdVries committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c520047 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/DEI-225-filter-extremes-rule

    @CindyvdVries
    CindyvdVries committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f30af19 View commit details
    Browse the repository at this point in the history

  3. import mistake

    @CindyvdVries
    CindyvdVries committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    52f3721 View commit details
    Browse the repository at this point in the history

  4. update test

    @CindyvdVries
    CindyvdVries committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8121c43 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Update parser_filter_extremes_rule.py

    @CindyvdVries
    CindyvdVries committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c918386 View commit details
    Browse the repository at this point in the history

  2. fix for lower python versions (<3.11)

    @CindyvdVries
    CindyvdVries committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e395267 View commit details
    Browse the repository at this point in the history

  3. and get back the str not the enumerate

    @CindyvdVries
    CindyvdVries committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    bb6ba00 View commit details
    Browse the repository at this point in the history