Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering strategy not as expected #224

Closed
2 tasks done
peterdgr opened this issue Nov 12, 2024 · 0 comments · Fixed by #225 or #228
Closed
2 tasks done

Ordering strategy not as expected #224

peterdgr opened this issue Nov 12, 2024 · 0 comments · Fixed by #225 or #228
Assignees
Labels
bug Something isn't working enhancement New feature or request invalid This doesn't seem right

Comments

@peterdgr
Copy link
Collaborator

Koswat version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of Koswat in master here.

Koswat version

master

Reproducible example

Current behaviour

In determining the ordering strategy after sorting (based on neccesary space and cost) a pairwise check is made to see which measures should be kept. This check should not only be pairwise, but take all following measures into account. In the end the cheapest option should always be prefered!

Furthermore, the order should be based on the cost/km including surcharge factor!

  Cost Space Resultaat Verwacht
Grondmaatregel profiel 2.0277795 9.66 1 0
Verticale piping oplossing 4.4685446 19.66 0 -1
Kwelscherm 6.2404688 9.66 -1 -1
Stabiliteitswand 12.090818 1.68 2 1
Kistdam 20.881029 0 3 2

Desired behaviour

See the supplied table

Additional context

No response

@peterdgr peterdgr added bug Something isn't working enhancement New feature or request invalid This doesn't seem right labels Nov 12, 2024
@peterdgr peterdgr added this to the Sprint 2024.4.2 milestone Nov 12, 2024
@ArdtK ArdtK linked a pull request Nov 12, 2024 that will close this issue
6 tasks
@ArdtK ArdtK linked a pull request Nov 13, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request invalid This doesn't seem right
Projects
None yet
2 participants