GeomsComponent._region_data
crashes on too little arguments
#1079
Labels
GeomsComponent._region_data
crashes on too little arguments
#1079
HydroMT version checks
Reproducible Example
Cannot provide this, happened somewhere in trial/error of updating hydromt_delft3dfm to hydromt v1, but cannot reproduce this easily anymore.
Current behaviour
Error about missing ymin/xmax/ymax arguments for shapely.box in
GeomsComponent._region_data
:hydromt/hydromt/model/components/geoms.py
Lines 87 to 102 in ea0d1d3
Probably because all four arguments are passed as a tuple to
xmin
.Desired behaviour
I think because the code should read
box(*total_bounds)
instead ofbox(total_bounds)
so all four arguments are separately passed instead.Additional context
I meant to check the code coverage since this cannot possibly be covered by tests if my hypothesis is correct. However, the code coverage has not been updated for a year so I cannot check this. For that issue I created #1077
The text was updated successfully, but these errors were encountered: