Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #1094

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Python 3.12 support #1094

wants to merge 25 commits into from

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Oct 22, 2024

Issue addressed

Fixes #540

Explanation

Just checking if all tests pass with Python 3.12:

  • added py312 to pixi tests
  • there are many DeprecationWarnings that cause ERRORS, for instance: ERROR tests/data_catalog/test_data_catalog.py::test_export_global_datasets_overrwite - DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior. - This comes from pooch.retrieve() or actually the passed processor=pooch.Untar which calls tar_file.extractall(). I hoped to resolve it by passing a filter='data' argument to the processer pooch.Untar, but this is not supported. Instead, I have added this to filterwarnings in pyproject.toml.
  • after the changes above, the tests pass in the test workflow.

General Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation >> yes, toml and readme are updated so supported versions will be visible on pypi and github after the next release (via classifiers and readme badge)
  • Updated changelog.rst >> no, to avoid conflicts, could be "Added support for Python 3.12 (Python 3.12 support #1094)"

Data/Catalog checklist

  • data/catalogs/predefined_catalogs.yml has not been modified.
  • None of the old data_catalog.yml files have been chagned
  • data/chagnelog.rst has been updated
  • new file uses LF line endings (done automatically if you used update_versions.py)
  • New file has been tested locally
  • Tests have been added using the new file in the test suite

@veenstrajelmer veenstrajelmer linked an issue Oct 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.12
1 participant