Adds support for encrypted RSA private keys in decrypt_oaep and rsa_sign functions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to jwk in rsa_verify, hmac_sign and hmac_verify functions.
|
Added support for encrypted RSA private keys (decrypt and sign): jwk = {"k": PEMPrivateKey, "passphrase": keyPassphrase} Please take a look on the failed Travis CI. The build fails when hmac_sign is called for encryption/decryption and not for signing/verification. |
0xacb
changed the title
0xacb
changed the title
|
@abaptista Hi Andre, thank you for your contribution! I'm happy to merge this but it needs all the existing tests to be fixed up (you have changed the API of some of the algorithms), and also needs unit tests for keys with passphrases. |
|
@nmurtagh Hello! Sure, I understand. I'm happy to contribute, please let me know if you need a hand 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.