Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clustering yaml creayed #202

Merged
merged 8 commits into from
Apr 26, 2024
Merged

clustering yaml creayed #202

merged 8 commits into from
Apr 26, 2024

Conversation

giuliaelgarcia
Copy link
Collaborator

Created clustering yaml file.
Please check line 267 for default and check formating from line 140 onwards (when there are 2 default values)

bio-la
bio-la requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@bio-la bio-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pull again the branch (i've added some fixes) and check my comments.
I've added the file to the index so you can see the documentation rendered and check how the structure looks.
please be careful with spelling typos

docs/yaml_docs/pipeline_clustering_yml.md Outdated Show resolved Hide resolved
docs/yaml_docs/pipeline_clustering_yml.md Outdated Show resolved Hide resolved
@bio-la bio-la self-requested a review March 4, 2024 10:22
bio-la
bio-la reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@bio-la bio-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please spell check!

docs/yaml_docs/pipeline_clustering_yml.md Outdated Show resolved Hide resolved
docs/yaml_docs/pipeline_clustering_yml.md Outdated Show resolved Hide resolved
deevdevil88
deevdevil88 requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@deevdevil88 deevdevil88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos and mincells explanation needs to be changed

@bio-la bio-la self-requested a review April 24, 2024 14:17
bio-la
bio-la reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@bio-la bio-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • clarified modalities
  • removed wrong parameters

@bio-la bio-la self-requested a review April 24, 2024 15:13
@bio-la bio-la requested a review from deevdevil88 April 24, 2024 15:14
@bio-la bio-la merged commit 844e4a0 into main Apr 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deevdevil88 deevdevil88 deevdevil88 approved these changes

@bio-la bio-la bio-la approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giuliaelgarcia @bio-la @deevdevil88