Linux build fixes: remove unused osMutex code and typedefs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
th1000s
commented
Apr 16, 2024
•
th1000s
commented
- Remove superfluous typedefs
- gcc: disable -Wnarrowing via pragma in snd8to16.h
- Remove linux/ipx.h include
- Remove unused osMutex code. It was never Acquire'd, only Created and Destroyed; and it was a stub on Linux and macOS.
This header was removed with linux 5.15
It was never Acquire'd, only Created and Destroyed; and it was a stub on Linux and macOS.
|
Hi, can you explain what the changes are? I see you removing the mutex code and some other things, but an explanation as to why will be nice :). |
The commit messages are well documented, I edited the description :) |
Lgt2x
changed the title
JeodC
pushed a commit
that referenced
this pull request
Apr 28, 2024
Linux build fixes: remove unused osMutex code and typedefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.