Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance mission levels select window #613

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This PR was inspired by #485. Now missions that contains more that one level, shows enhanced level select window (see screenshot). This enhancement allows user to select available level instead of input number of mission manually. Additional refactoring made for filename paths used in related functions.

Related Issues

Screenshots (if applicable)

Descent3_mission_levels

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@JeodC
Copy link
Collaborator

JeodC commented Sep 29, 2024

Nice work, it looks great! Tested in Windows. Do you mind if the core missions go to the top of the list? See here for reference. I also really like the idea of the LEVEL SELECT header being the name of the current mission, as a reference for the user. This was done in the old PR that inspired this current one.

image

@winterheart
Copy link
Collaborator Author

Nice work, it looks great! Tested in Windows. Do you mind if the core missions go to the top of the list? See here for reference. I also really like the idea of the LEVEL SELECT header being the name of the current mission, as a reference for the user. This was done in the old PR that inspired this current one.

I'm planning to rewrite "New Game" UI flow and divide Campaign and Mission select to different screens. Regarding "Level select" title I'll add name of mission.

@winterheart
Copy link
Collaborator Author

Changed "Select Level" with mission name.

@Lgt2x Lgt2x self-assigned this Oct 15, 2024
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this new feature! Tested with success on Linux. I also have a request, not necessarily for this MR: it could be great to display the number of levels of a mission in the "info" dialog below the "notes" header when selecting the mission.

Descent3/LoadLevel.cpp Outdated Show resolved Hide resolved
Descent3/LoadLevel.cpp Show resolved Hide resolved
Descent3/LoadLevel.cpp Outdated Show resolved Hide resolved
Descent3/LoadLevel.h Outdated Show resolved Hide resolved
Descent3/Mission.cpp Outdated Show resolved Hide resolved
Descent3/Mission.cpp Outdated Show resolved Hide resolved
Descent3/Mission.h Outdated Show resolved Hide resolved
Descent3/menu.cpp Show resolved Hide resolved
This function may be used for fast information accessing such as level name or description.
Now level loading screen shows level name, and user can choose level from list instead of manually entering level number.
@winterheart
Copy link
Collaborator Author

I also have a request, not necessarily for this MR: it could be great to display the number of levels of a mission in the "info" dialog below the "notes" header when selecting the mission.

That would be kinda spoiler for player, he will know how many missions are left.

Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again on Linux, I think we're good now!

@Lgt2x Lgt2x merged commit 496b2ed into DescentDevelopers:main Oct 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants