Skip to content

Commit

Permalink
Merge pull request #10036 from DestinyItemManager/font-mods-open-in-o…
Browse files Browse the repository at this point in the history
…ptimizer

Turn Include Font mod stats into a LoadoutParameter, configure LO with results from analysis
  • Loading branch information
robojumper committed Nov 6, 2023
2 parents 8fb6c0e + 62bac5f commit dd67d79
Show file tree
Hide file tree
Showing 29 changed files with 729 additions and 67 deletions.
7 changes: 6 additions & 1 deletion config/i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,8 @@
"Equip": "Equip on {{character}}",
"Exclude": "Excluded Items",
"ExcludeHelp": "Shift + click an item (or drag and drop into this bucket) to build sets without specific gear.",
"ExistingBuildStats": "Existing Build Stats",
"ExistingBuildStatsNote": "Only showing builds with strictly higher stat tiers.",
"FilterSets": "Filter sets",
"Help": {
"And": "Armor with all of these perks will be used (\"and\")",
Expand Down Expand Up @@ -687,6 +689,8 @@
"Error404": "This loadout doesn't exist.",
"Error": "Error getting loadout:"
},
"IncludeRuntimeStatBenefits": "Include Font mod stats",
"IncludeRuntimeStatBenefitsDesc": "\"Font of ...\" armor mods provide a flat boost to character stats while you have Armor Charges.\n\nWith this setting, DIM considers these mods active and adds their benefits to this Loadout's stats in calculations and optimizations.",
"InGameLoadouts": "In-Game Loadouts",
"ItemLeveling": "Item Leveling",
"LoadoutName": "Loadout name",
Expand Down Expand Up @@ -818,6 +822,7 @@
"LoadoutAnalysis": {
"Analyzing": "Analyzing {{numAnalyzed}}/{{numLoadouts}} Loadouts",
"Analyzed": "Analyzed {{numLoadouts}} Loadouts",
"BetterStatsAvailableFontNote": "Note: This Loadout uses \"Font of ...\" mods that cause a stat tier to exceed T10. DIM may identify better stats by reducing the amount of excess tiers. If this is undesired, disable \"$t(Loadouts.IncludeRuntimeStatBenefits)\" in the Loadout.",
"MissingItems": {
"Name": "Missing Items",
"Description": "Some of the items in this loadout are no longer in your inventory."
Expand All @@ -840,7 +845,7 @@
},
"BetterStatsAvailable": {
"Name": "Better Stats Available",
"Description": "Choosing different armor or mods for this loadout will allow reaching higher stat tiers."
"Description": "Choosing different armor or mods for this loadout will allow reaching higher stat tiers. Choose \"$t(Loadouts.OpenInOptimizer)\" to view better builds."
},
"NotAFullArmorSet": {
"Name": "Not A Full Armor Set",
Expand Down
1 change: 1 addition & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default {
$DIM_VERSION: '1.0.0',
$featureFlags: {
dimApi: true,
runLoInBackground: true,
},
},
};
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/app/dim-api/selectors.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { defaultLoadoutParameters, DestinyVersion } from '@destinyitemmanager/dim-api-types';
import { DestinyVersion, defaultLoadoutParameters } from '@destinyitemmanager/dim-api-types';
import { DestinyAccount } from 'app/accounts/destiny-account';
import { currentAccountSelector, destinyVersionSelector } from 'app/accounts/selectors';
import { Settings } from 'app/settings/initial-settings';
Expand Down
Loading

0 comments on commit dd67d79

Please sign in to comment.