-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enhanced/enhanceable keywords #10718
Update enhanced/enhanceable keywords #10718
Conversation
Add range to enhanced and update logic to show any enhanced instead of fully-enhanced Exclude enhanced:3 from enhanceable
With the caveat that I don't really know anything about enhancement, I think I'd still expect |
With the way it works in-game, the weapon says "this can be enhanced" when it's enhanceable, then "this can be further enhanced" when it's on tier 1/2 of enhancement. I'd say that any tier of enhancement should count as enhanced, and that'll also line up with our |
} | ||
}, | ||
format: ['simple', 'range'], | ||
filter: ({ lhs, compare }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add an extra condition for whether the enhance plug exists - that way enhanceable:0
would light up all items that are enhanceable but which have not been enhanced at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was debating whether to include non-enhanceable weapons in enhanced:0 (and not:enhanced) or not. Will start a discussion in Discord.
Fixes #10719
Add range to enhanced and update logic to show any enhanced instead of fully-enhanced
Exclude enhanced:3 from enhanceable
Also update changelog
is:enhanced
andenhanced:>0
now show anything t1-3is:enhanceable
now shows anything t0-2 that's enhanceableThe other ranges work as expected.