Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enhanced/enhanceable keywords #10718

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Sep 3, 2024

Fixes #10719
Add range to enhanced and update logic to show any enhanced instead of fully-enhanced
Exclude enhanced:3 from enhanceable

Also update changelog

is:enhanced and enhanced:>0 now show anything t1-3
is:enhanceable now shows anything t0-2 that's enhanceable
The other ranges work as expected.

Add range to enhanced and update logic to show any enhanced instead of fully-enhanced
Exclude enhanced:3 from enhanceable
@bhollis
Copy link
Contributor

bhollis commented Sep 4, 2024

With the caveat that I don't really know anything about enhancement, I think I'd still expect is:enhanced to be fully-enhanced.

@FlaminSarge
Copy link
Contributor Author

With the caveat that I don't really know anything about enhancement, I think I'd still expect is:enhanced to be fully-enhanced.

With the way it works in-game, the weapon says "this can be enhanced" when it's enhanceable, then "this can be further enhanced" when it's on tier 1/2 of enhancement. I'd say that any tier of enhancement should count as enhanced, and that'll also line up with our item.crafted === 'enhanced' logic.

}
},
format: ['simple', 'range'],
filter: ({ lhs, compare }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add an extra condition for whether the enhance plug exists - that way enhanceable:0 would light up all items that are enhanceable but which have not been enhanced at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating whether to include non-enhanceable weapons in enhanced:0 (and not:enhanced) or not. Will start a discussion in Discord.

@bhollis bhollis merged commit 33459ea into DestinyItemManager:master Sep 6, 2024
6 checks passed
@FlaminSarge FlaminSarge deleted the enhancement-search branch September 7, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement tier filters ? we could do an overload on the term enhanced?
2 participants