Upgrade to gradle 8.0.2, fix proguard rules for r8 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VicV
commented
Jul 7, 2023
VicV
commented
Jul 7, 2023
android-client-sdk/src/main/java/com/devcycle/sdk/android/model/PopulatedUser.kt
Outdated
Show resolved
Hide resolved
VicV
commented
Jul 7, 2023
android-client-sdk/src/main/java/com/devcycle/sdk/android/model/PopulatedUser.kt
Outdated
Show resolved
Hide resolved
VicV
commented
Jul 7, 2023
android-client-sdk/src/main/java/com/devcycle/sdk/android/model/PopulatedUser.kt
Outdated
Show resolved
Hide resolved
VicV
commented
Jul 7, 2023
android-client-sdk/src/main/java/com/devcycle/sdk/android/util/DVCSharedPrefs.kt
Show resolved
Hide resolved
VicV
commented
Jul 7, 2023
VicV
commented
Jul 7, 2023
laurawarr
force-pushed
the
DVC-8107/R8-compatibility
branch
from
0204e82
to
81ab697
Compare
laurawarr
reviewed
Jul 10, 2023
android-client-sdk/src/test/java/com/devcycle/sdk/android/api/DVCClientTests.kt
Outdated
Show resolved
Hide resolved
laurawarr
force-pushed
the
DVC-8107/R8-compatibility
branch
2 times, most recently
from
6f12e8a
to
8a83a5e
Compare
laurawarr
force-pushed
the
DVC-8107/R8-compatibility
branch
10 times, most recently
from
139805a
to
c465e65
Compare
laurawarr
force-pushed
the
DVC-8107/R8-compatibility
branch
from
c465e65
to
5112d00
Compare
kaushalkapasi
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main problem
The newest R8 strips a lot of stuff when its enabled.
I copied a ton of the details from here to add to our proguard consumer file:
square/retrofit#3751
I also added a ton of protections around the jackson lib so that those types and files don't get stripped as well.
Main item here too is making sure we
keepthe Android folder as it contains the coroutine schedule, objectmapper, and how we read configs locally and from the APIOther notes