feat: add method which return current cdp #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
PavelMor25
removed
the
STATE: Need response
Aleksey28
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Please, look at my comments. After that update type definitions here https://github.com/DevExpress/testcafe/tree/master/ts-defs-src
test/functional/fixtures/regression/gh-479-private/testcafe-fixtures/index.js
Outdated
Show resolved
Hide resolved
Aleksey28
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Please, look at my comments, and also add definition tests to this directory: https://github.com/DevExpress/testcafe/blob/master/test/server/compiler-test.js
As example, you can explore how it was made for getCurrentWindow.
PavelMor25
commented
Mar 28, 2024
Aleksey28
approved these changes
Mar 28, 2024
Bayheck
approved these changes
Mar 29, 2024
titerman
reviewed
Mar 29, 2024
titerman
approved these changes
Mar 29, 2024
Co-authored-by: Gene <43554315+titerman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes Devexpress/testcafe-private/issues/479
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO