Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 4.2+ #32

Closed
alexandernst opened this issue Jul 4, 2024 · 10 comments
Closed

Support Django 4.2+ #32

alexandernst opened this issue Jul 4, 2024 · 10 comments

Comments

@alexandernst
Copy link
Member

This app, as it is, won't work with Django 4.2+ because of a deprecation that django did regarding the way DEFAULT_FILE_STORAGE works.

https://docs.djangoproject.com/en/5.0/releases/4.2/#custom-file-storages

@patroqueeet
Copy link
Collaborator

hm, running it here w/ 4.2 without any probs. 🤔

@alexandernst
Copy link
Member Author

My bad. It only got deprecated in 4.2, not removed. Still, we should migrate to the new STORAGES setting as the previous behavior will get removed eventually.

@patroqueeet
Copy link
Collaborator

@alexandernst will you make a PR?

@alexandernst
Copy link
Member Author

@patroqueeet Not sure 🤔, currently I don't have any spare time to dedicate to this. If nobody beats me to it, I'll eventually patch it, but it might not be soon.

@patroqueeet
Copy link
Collaborator

ack, should we do a quick release to get the latest changes out @alexandernst ?

@alexandernst
Copy link
Member Author

alexandernst commented Jul 16, 2024 via email

@patroqueeet
Copy link
Collaborator

👏

@patroqueeet
Copy link
Collaborator

@alexandernst closable after #40 ?

@alexandernst
Copy link
Member Author

Yes, this is closable :) . Do the honors! 🙏

@patroqueeet
Copy link
Collaborator

done with #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants