Parse Log entries #23
Conversation
Create event loop, if code is executing in non-main thread.
Starting from Python 3, the __str__ method was introduced as a replacement for __unicode__ to provide a string representation of an object.
# Conflicts: # django_walletpass/admin.py # django_walletpass/models.py
…//xxxx/passes/) encountered error: Unexpected response code 404
|
good morning @cherijs very well done! excellent improvement. would adding a filter for |
I added list_filter = ("status", "task_type", "pass_type_identifier") already :) 
|
django_walletpass/classviews.py
Outdated
| @@ -27,6 +27,10 @@ def get_pass(pass_type_id, serial_number): | |||
| return get_object_or_404(Pass, pass_type_identifier=pass_type_id, serial_number=serial_number) | |||
|
|
|||
|
|
|||
| def web_service_root_view(request): | |||
There was a problem hiding this comment.
this is not a classview. should either inherit from View or in views.py I assume. actually, what is the intention of this view? @cherijs
There was a problem hiding this comment.
However, it seems that this view should be taken out.
I understood when this error came about not being able to open web_service_url:
WALLETPASS["SERVICE_URL"] = 'https://xxx/api/passes/'
[2023-07-09 12:18:47 +0300] Register task (for device 6d07103565a61da35b0cb6047736518a, pass type pass.id.lolo.tickets, serial number R1e7lciJx5K_j6_m4iNouABbUXY; with web service url https://xxx/api/passes/) encountered error: Unexpected response code 404
but i was wrong...
this error was about not being able to open paass R1e7lciJx5K_j6_m4iNouABbUXY not SERVICE_URL root
|
|
||
| def wallet_pass_(self, obj: Pass): | ||
| if obj.data: | ||
| svg_icon = '<svg width="13" height="16" viewBox="0 0 13 16" fill="none" xmlns="http://www.w3.org/2000/svg">' \ |
There was a problem hiding this comment.
what is this icon for? how would it look like? @cherijs
There was a problem hiding this comment.
I'll copy&paste what I wrote in the other PR. I don't know how I feel about hardcoding the content of a svg file here. Can we maybe load this from a file?
…m server, and we are updating pass.
…eted from server, and we are updating pass." This reverts commit 62cd074.
…ken with 164 chars
|
Is this ready to merge? |
not yet, I believe. the SVG might be better in a static file |
|
@patroqueeet if you're feeling brave enough, maybe clone cherijs's branch and apply the change to the svg? |
|
This was merged in #29 |
Parse log entries and split into smaller parts, link to pass object
