add django test matrix #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be dj5 ready
|
@alexandernst @NachE ready to merge. good of you? |
This reverts commit 0d08592.
|
are these changes enough to consider django 5 supported? /cc @alexandernst |
patroqueeet
added a commit
to patroqueeet/django-walletpass
that referenced
this pull request
Aug 22, 2024
I believe so. At least tests pass. Haven't run it in PROD env yet. |
|
Up to Django 4.2 it wasn't possible to have multiple storages (not in an easy way). Starting with 4.2 django encourages users to actually use multiple storages, that's why we shouldn't asume the |
see 4f7df0c. good of for you? |
|
@NachE @alexandernst good to merge? any improvements reasonable? |
|
I think we're good! Feel free to merge 🙏 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to related Django settings deprecation in v4.2 let's ensure all versions keep working
addresses #32