Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PEDM refactoring #1091

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Initial PEDM refactoring #1091

merged 13 commits into from
Nov 5, 2024

Conversation

thenextman
Copy link
Member

@thenextman thenextman commented Nov 5, 2024

This is a work-in-progress refactoring of the PEDM module, while we get to grips with the functionality and take the prototype to something releasable. Subsequent PRs will be more focused.

This pull request:

  • Patches memory bugs in security primitives (in the sid, privilege and token modules) that were causing runtime crashes in debug builds and clear undefined behaviour otherwise
  • Disables logging of PEDM elevations. The log target is determined based on finding the file for the current day, but misses the fact that we might not roll the log file daily. This will be replaced by a database-backed logging solution.
  • Disables configuration of secure program data directories. The functionality is currently broken due to a loosely defined bug in the relevant security primitives.
  • Remove the rules configuration from the core API and regenerates clients accordingly
  • Introduces a revised PEDM desktop agent, running as a system tray application and using system notifications

A follow up PR will integrate packaging and build for the revised PEDM desktop agent.

Copy link

github-actions bot commented Nov 5, 2024

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@CBenoit CBenoit merged commit b5cfced into master Nov 5, 2024
26 checks passed
@CBenoit CBenoit deleted the pedm-refactor branch November 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants