Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature multiple selection was added. #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CristianMG
Copy link

@CristianMG CristianMG commented Apr 27, 2022

🚀 Description

New feature was added, multiple picker selection.
This feature is only availabe as picker and compression, not crop. The feature allows user to select multiple files from gallery and it's will be crompress, this feature is only for the new picker mode not legacy intent.

📄 Motivation and Context

The motivation is clear, give a feature neccesary multiple files selector.

🧪 How Has This Been Tested?

Tested with the example, but I haven't the neccesary know how to test properly.

📦 Types of changes

  • [x ] Added new worker coroutines to compress images, this is the properly method nowadays reccommended by Google. Added consequently the coroutines library to do it.
  • [ x] New feature, multiple selection library
  • [x ] Breaking change, old user legacy library can't use this feature.

✅ Checklist

  • My change will required a deep testing of library.
  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.

New feature to select multiple files with the option multiplePicker, async task was changed by coroutine worker, this is the new reccommended way by google to make async task.

Some code refactor.

Commented  // mCropProvider.delete() because, it was removing image after generate, it was causing an error that image wasn't available when client wanted to consumed.
@PatricioIN
Copy link

It's working correctly! Once the property is lost so that it returns several images, the callback is called as many times as images have been selected, and they are added to the files/DCIM folder

@nasserr
Copy link

nasserr commented Jul 20, 2022

Why is not merged ? It take too much time...

@hardikflatworldsolutions

This should be merged. Thanks

@axel7083
Copy link

I would love this feature to be merged!

@paulsUsername
Copy link

Be great to merge this!

@EkaterinaT89
Copy link

I would be really love to have this option. Could you tell me when we have it?

@axel7083
Copy link

axel7083 commented Sep 4, 2023

@EkaterinaT89 Probably never since the last merged in this repository is 2021

@jshafer817
Copy link

Why was this not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants