This repository has been archived by the owner on Mar 27, 2018. It is now read-only.
Regions (DO NOT MERGE) #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerring
commented
Feb 22, 2017
| return new Point(m.group(4), Integer.parseInt(m.group(5)), Double.parseDouble(m.group(6)), | ||
| m.group(1), Integer.parseInt(m.group(2)), Double.parseDouble(m.group(3))); | ||
| } | ||
| throw new RuntimeException("Unparsable string "+asString); |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one. 
gerring
commented
Feb 22, 2017
| @@ -135,4 +135,23 @@ public int getIndex(String name) { | |||
| } | |||
| return indices; | |||
| } | |||
|
|
|||
| private static final String VERTEX = "([a-zA-Z0-9_])+\\((\\d+)\\)=([-+]?[0-9]*\\.?[0-9]+)"; | |||
There was a problem hiding this comment.
Move this variable to comply with Java Code Conventions.
gerring
commented
Feb 22, 2017
| @@ -135,4 +135,23 @@ public int getIndex(String name) { | |||
| } | |||
| return indices; | |||
| } | |||
|
|
|||
| private static final String VERTEX = "([a-zA-Z0-9_])+\\((\\d+)\\)=([-+]?[0-9]*\\.?[0-9]+)"; | |||
| private static final Pattern POSITION = Pattern.compile(VERTEX+", "+VERTEX); | |||
There was a problem hiding this comment.
Move this variable to comply with Java Code Conventions.
|
SonarQube analysis reported 3 issues
Watch the comments in this conversation to review them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.