Fix pre-commit errors

.vscode/tasks.json

@@ -21,4 +21,4 @@
             "type": "shell"
         }
     ]
-}
+}

docs/_templates/autosummary/module.rst

@@ -64,4 +64,3 @@
    {%- endfor %}
    {% endif %}
    {% endblock %}
-

docs/how-to/create-beamline.rst

@@ -79,4 +79,3 @@ The following example creates a fictitious beamline ``w41``, with a simulated tw
 This test checks that the function returns a type that conforms to Bluesky protocols, 
 that it always returns the same instance of the device and that the arguments passed 
 into the Device class constructor are valid.
-

docs/how-to/make-new-ophyd-async-device.rst

@@ -64,4 +64,4 @@ Additional Notes
 - ``with self.add_children_as_readables():`` Ensure this context manager is used appropriately in the device implementation to add child components as readable properties, but not Movables.
 
 
-.. _ophyd-async: https://blueskyproject.io/ophyd-async/main/how-to/choose-interfaces-for-devices.html
+.. _ophyd-async: https://blueskyproject.io/ophyd-async/main/how-to/choose-interfaces-for-devices.html

docs/how-to/zocalo.rst

@@ -10,4 +10,4 @@ processing from data in ISPyB.
 
 Results are received using the ``ZocaloResults`` device, so that they can be read into a plan and used for 
 decision-making. Currently the ``ZocaloResults`` device is only made to handle X-ray centring results. It subscribes to 
-a given zocalo RabbitMQ channel the first time that it is triggered.
+a given zocalo RabbitMQ channel the first time that it is triggered.

docs/reference/device-standards.rst

@@ -98,4 +98,4 @@ Ophyd Devices best practices
 Ophyd-async directory contains a flowchart_ for a simplified decision tree about what interfaces
 should a given device implement.
 
-.. _flowchart: https://blueskyproject.io/ophyd-async/main/how-to/choose-interfaces-for-devices.html
+.. _flowchart: https://blueskyproject.io/ophyd-async/main/how-to/choose-interfaces-for-devices.html

docs/reference/standards.rst

@@ -74,4 +74,4 @@ Docs follow the underlining convention::
 
 .. seealso::
 
-    How-to guide `../how-to/build-docs`
+    How-to guide `../how-to/build-docs`

docs/tutorials/get_started.rst

@@ -49,4 +49,4 @@ If you would like to only log to graylog/file exlusively there are helper functi
 
 .. _ophyd: https://nsls-ii.github.io/ophyd/
 .. _bluesky: https://blueskyproject.io/bluesky/
-.. _graylog: https://graylog-log-target.diamond.ac.uk/search
+.. _graylog: https://graylog-log-target.diamond.ac.uk/search

src/dodal/devices/aperturescatterguard.py

@@ -174,7 +174,7 @@ class SelectedAperture(SignalR):
         async def read(self, *args, **kwargs):
             assert isinstance(self.parent, ApertureScatterguard)
             assert self._backend
-            await self._backend.put(await self.parent._get_current_aperture_position())
+            await self._backend.put(await self.parent.get_current_aperture_position())
             return {self.name: await self._backend.get_reading()}
 
         async def describe(self) -> dict[str, DataKey]:
@@ -224,7 +224,7 @@ async def _set_raw_unsafe(self, positions: ApertureFiveDimensionalLocation):
             self.scatterguard.y.set(scatterguard_y),
         )
 
-    async def _get_current_aperture_position(self) -> SingleAperturePosition:
+    async def get_current_aperture_position(self) -> SingleAperturePosition:
         """
         Returns the current aperture position using readback values
         for SMALL, MEDIUM, LARGE. ROBOT_LOAD position defined when

src/dodal/devices/areadetector/adutils.py

@@ -31,7 +31,7 @@ def trigger(self):
 
         def _acq_done(*args, **kwargs):
             # TODO sort out if anything useful in here
-            self._status._finished()
+            self._status.set_finished()
 
         self._acquisition_signal.put(1, use_complete=True, callback=_acq_done)
         # Ensure that this mixin is part of valid Detector with generate_datum

src/dodal/devices/oav/microns_for_zoom_levels.json

@@ -52,4 +52,4 @@
         "micronsPerXPixel": 0.227,
         "micronsPerYPixel": 0.314
     }
-}
+}

tests/common/test_coordination.py

@@ -16,7 +16,7 @@ def test_group_uid(group: str):
 
 
 def test_type_checking_ignores_inject():
-    def example_function(x: Movable = inject("foo")) -> MsgGenerator:
+    def example_function(x: Movable = inject("foo")) -> MsgGenerator:  # noqa: B008
         yield from {}
 
     # These asserts are sanity checks

tests/devices/unit_tests/test_OAVCentring.json

@@ -67,4 +67,4 @@
 		"CannyEdgeLowerThreshold": 5.0,
 		"brightness": 90
 	}
-}
+}