Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make device factory decorator #597

Closed
wants to merge 85 commits into from
Closed

make device factory decorator #597

wants to merge 85 commits into from

Commits on Oct 15, 2024

  1. example beamline with implementation

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    87e9e36 View commit details
    Browse the repository at this point in the history

  2. small cleanup

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dee1d0e View commit details
    Browse the repository at this point in the history

  3. added controller demonstration

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    45828c0 View commit details
    Browse the repository at this point in the history

  4. fix wrong extension

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2a7efa0 View commit details
    Browse the repository at this point in the history

  5. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8531403 View commit details
    Browse the repository at this point in the history

  6. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0490806 View commit details
    Browse the repository at this point in the history

  7. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    39e372b View commit details
    Browse the repository at this point in the history

  8. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    11b1671 View commit details
    Browse the repository at this point in the history

  9. fix example beamline into a dataclass

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    28bcad1 View commit details
    Browse the repository at this point in the history

  10. new-i22 as an example

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    698ec5b View commit details
    Browse the repository at this point in the history

  11. respond to feedback

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a8a925f View commit details
    Browse the repository at this point in the history

  12. respond to comments

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e2a517f View commit details
    Browse the repository at this point in the history

  13. initial test

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cb5211e View commit details
    Browse the repository at this point in the history

  14. comment out some tests to check coverage

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1f139f7 View commit details
    Browse the repository at this point in the history

  15. lint

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    42e4c2c View commit details
    Browse the repository at this point in the history

  16. use factory name for active devices dict key

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    035e34a View commit details
    Browse the repository at this point in the history

  17. this cannot be active devices, globals harder to mock

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3caa89c View commit details
    Browse the repository at this point in the history

  18. amend the test

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    011f009 View commit details
    Browse the repository at this point in the history

  19. added a red test for caching by name

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    543ee47 View commit details
    Browse the repository at this point in the history

  20. fix the tests and add the support for a name flag

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    01ac2ab View commit details
    Browse the repository at this point in the history

  21. add the API for blueapi

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    248ea93 View commit details
    Browse the repository at this point in the history

  22. remove todos

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dabc376 View commit details
    Browse the repository at this point in the history

  23. unused utils deleted for coverage

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ce95b44 View commit details
    Browse the repository at this point in the history

  24. Just one i22 now

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    97c4c45 View commit details
    Browse the repository at this point in the history

  25. respond to comments

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c277821 View commit details
    Browse the repository at this point in the history

  26. rename to device factory

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f7578f9 View commit details
    Browse the repository at this point in the history

  27. is this enough to replace skip_device()

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f298379 View commit details
    Browse the repository at this point in the history

  28. ruff

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3cd8763 View commit details
    Browse the repository at this point in the history

  29. remove the connect default timeout =10

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    63a2211 View commit details
    Browse the repository at this point in the history

  30. add support for the terminal use case and some tests

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    152ff73 View commit details
    Browse the repository at this point in the history

  31. fix mock status and add the new decorator@

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c5b7d2e View commit details
    Browse the repository at this point in the history

  32. fix the tests

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dcb6102 View commit details
    Browse the repository at this point in the history

  33. delete bad comments, add good comments

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ffb41ee View commit details
    Browse the repository at this point in the history

  34. ruff

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    826e96f View commit details
    Browse the repository at this point in the history

  35. feedback response

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9e0be91 View commit details
    Browse the repository at this point in the history

  36. add return type annotation for testing coverage purposes

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2a4c432 View commit details
    Browse the repository at this point in the history

  37. respond to feedback

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cb43eb9 View commit details
    Browse the repository at this point in the history

  38. adapt tetramm

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    34d6c4e View commit details
    Browse the repository at this point in the history

  39. respond to feedback

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2e874c5 View commit details
    Browse the repository at this point in the history

  40. add repr that includes the config

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4660721 View commit details
    Browse the repository at this point in the history

  41. lint

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1d95a9a View commit details
    Browse the repository at this point in the history

  42. remove old panda ref

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7c90c0d View commit details
    Browse the repository at this point in the history

  43. fix import

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ddd583b View commit details
    Browse the repository at this point in the history

  44. fix the tests

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    01b5b7b View commit details
    Browse the repository at this point in the history

  45. pin pyright version due to is_device check failing

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    29fd6fc View commit details
    Browse the repository at this point in the history

  46. cancel pyright pinning

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    df1082b View commit details
    Browse the repository at this point in the history

  47. renaming

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    17a8f5f View commit details
    Browse the repository at this point in the history

  48. partial update to fix the test coverage for the factory

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    006e97a View commit details
    Browse the repository at this point in the history

  49. maybe fixed

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e02d9d4 View commit details
    Browse the repository at this point in the history

  50. imports fix

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8572b49 View commit details
    Browse the repository at this point in the history

  51. fix imports

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ef604dd View commit details
    Browse the repository at this point in the history

  52. forgot one

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3e1643a View commit details
    Browse the repository at this point in the history

  53. added test to increase coverage, still broken a bit

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    12980b5 View commit details
    Browse the repository at this point in the history

  54. towards a stable problem definitio a stable problme definition

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f5f6949 View commit details
    Browse the repository at this point in the history

  55. fix the test instance

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    048c7c7 View commit details
    Browse the repository at this point in the history

  56. finally fixed tests

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8f6c8ca View commit details
    Browse the repository at this point in the history

  57. lint

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3888726 View commit details
    Browse the repository at this point in the history

  58. fix tests

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    305f1d9 View commit details
    Browse the repository at this point in the history

  59. exit some tests early

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3bb1815 View commit details
    Browse the repository at this point in the history

  60. remove pytest skip

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8d1873f View commit details
    Browse the repository at this point in the history

  61. hardcode the i22 slit refs

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    48ad3d1 View commit details
    Browse the repository at this point in the history

  62. i22 remove device_instantiation

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a47b2d7 View commit details
    Browse the repository at this point in the history

  63. respond to feedback

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4a96f79 View commit details
    Browse the repository at this point in the history

  64. more tests to raise coverage

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d3020c7 View commit details
    Browse the repository at this point in the history

  65. respond to comment on the connect logic in controller call

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    31beeef View commit details
    Browse the repository at this point in the history

  66. deprecation warning added

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f704cb2 View commit details
    Browse the repository at this point in the history

  67. remove the v1 ophyd relevant piece of logic - fake_with_ophyd_sim

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e2887aa View commit details
    Browse the repository at this point in the history

  68. halfway through

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1af9cd7 View commit details
    Browse the repository at this point in the history

  69. identified the issue

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c75e693 View commit details
    Browse the repository at this point in the history

  70. name param issues

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    adef60b View commit details
    Browse the repository at this point in the history

  71. add new appropriate mocks

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    396cfbe View commit details
    Browse the repository at this point in the history

  72. merged the two dictionaries to preserve the connected functionality

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a986877 View commit details
    Browse the repository at this point in the history

  73. quickfix

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2aca80f View commit details
    Browse the repository at this point in the history

  74. try reverting the factory name change

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b58cb7a View commit details
    Browse the repository at this point in the history

  75. change the expected beamline in test_cli

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f4aa047 View commit details
    Browse the repository at this point in the history

  76. increase coverage

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2955088 View commit details
    Browse the repository at this point in the history

  77. fix lint newlien

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    580b7c9 View commit details
    Browse the repository at this point in the history

  78. add one more line

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    06954f1 View commit details
    Browse the repository at this point in the history

  79. linting

    @DiamondJoseph @stan-dot
    DiamondJoseph authored and stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    057080a View commit details
    Browse the repository at this point in the history

  80. remove unused imports

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0433521 View commit details
    Browse the repository at this point in the history

  81. restore the movable readable interface

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    259e68f View commit details
    Browse the repository at this point in the history

  82. respond to feedback

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9321f4c View commit details
    Browse the repository at this point in the history

  83. apply suggestions to the i22.py

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7553a97 View commit details
    Browse the repository at this point in the history

  84. respond to feedback

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c28c7c4 View commit details
    Browse the repository at this point in the history

  85. add hasattr to the module parsing

    @stan-dot
    stan-dot committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c2e8553 View commit details
    Browse the repository at this point in the history