-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for murko found from beamline testing #809
Open
DominicOram
wants to merge
10
commits into
main
Choose a base branch
from
530_only_stream_OAV_on_updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
changed the title
530 only stream oav on updates
Only stream OAV to redis when OAV updates and other changes for murko found from beamline testing
Sep 27, 2024
DominicOram
changed the title
Only stream OAV to redis when OAV updates and other changes for murko found from beamline testing
Changes for murko found from beamline testing
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 120 120
Lines 4976 4978 +2
=======================================
+ Hits 4737 4739 +2
Misses 239 239 ☔ View full report in Codecov by Sentry. |
DominicOram
requested review from
aragaod,
dperl-dls,
olliesilvester,
rtuck99 and
noemifrisina
September 27, 2024 12:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/mx-bluesky#530 and DiamondLightSource/mx-bluesky#147
Built on top of #808 so review/merge that first
Additionally this PR:
Instructions to reviewer on how to test:
dodal connect i04
Checks for reviewer
dodal connect ${BEAMLINE}