Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for murko found from beamline testing #809

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

DominicOram
Copy link
Contributor

Fixes DiamondLightSource/mx-bluesky#530 and DiamondLightSource/mx-bluesky#147

Built on top of #808 so review/merge that first

Additionally this PR:

  • Changes the format of data we store in redis to be just the raw JPEG bytes. This was done after discussion with @aragaod to reduce the memory usage of the redis database.
  • Adds a timeout of 30s and so will not stream data for longer than this, FYI @aragaod. We can update this timeout later if needed

Instructions to reviewer on how to test:

  1. Confirm tests still pass
  2. Confirm device still connects with dodal connect i04

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram changed the title 530 only stream oav on updates Only stream OAV to redis when OAV updates and other changes for murko found from beamline testing Sep 27, 2024
@DominicOram DominicOram changed the title Only stream OAV to redis when OAV updates and other changes for murko found from beamline testing Changes for murko found from beamline testing Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (0ba531c) to head (80652e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         120      120           
  Lines        4976     4978    +2     
=======================================
+ Hits         4737     4739    +2     
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram marked this pull request as ready for review September 27, 2024 12:20
Base automatically changed from mx_bluesky_511_murko_fixes to main October 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Murko: Only stream image to redis when the OAV updates
1 participant